[tracker] tracker-tag: Improve on patch earlier in the week by Saleem Abdulrasool



commit 5fb7c0ee48509671ff669ef594a19c335e42b602
Author: Martyn Russell <martyn lanedo com>
Date:   Thu Oct 8 09:52:40 2009 +0100

    tracker-tag: Improve on patch earlier in the week by Saleem Abdulrasool

 src/tracker-utils/tracker-tag.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/tracker-utils/tracker-tag.c b/src/tracker-utils/tracker-tag.c
index 337011d..90a7795 100644
--- a/src/tracker-utils/tracker-tag.c
+++ b/src/tracker-utils/tracker-tag.c
@@ -693,7 +693,7 @@ main (int argc, char **argv)
 
 		for (p = files; *p; p++) {
 			g_print ("<%s>\n", *p);
-			success = (success && get_tags_by_file (client, *p));
+			success &= get_tags_by_file (client, *p);
 			g_print ("\n");
 		}
 
@@ -704,5 +704,8 @@ main (int argc, char **argv)
 
 	tracker_disconnect (client);
 
-	return EXIT_SUCCESS;
+	/* This is a failure because we should have done something.
+	 * This code should never be reached in practise. 
+	 */ 
+	return EXIT_FAILURE;
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]