[libgda] Misc corrections

[Vivien Malerba <vivien src gnome org>]

commit 390cd01a072cefea11f30110282cd7cf490772e7
Author: Vivien Malerba <malerba gnome-db org>
Date:   Tue Oct 6 20:18:09 2009 +0200

    Misc corrections

 libgda-ui/data-entries/common-bin.c |    4 +++-
 libgda-ui/gdaui-basic-form.c        |   18 ++++++------------
 2 files changed, 9 insertions(+), 13 deletions(-)
---
diff --git a/libgda-ui/data-entries/common-bin.c b/libgda-ui/data-entries/common-bin.c
index 29561e3..2df2cd7 100644
--- a/libgda-ui/data-entries/common-bin.c
+++ b/libgda-ui/data-entries/common-bin.c
@@ -350,8 +350,10 @@ common_bin_adjust_menu (BinMenu *binmenu, gboolean editable, const GValue *value
 void
 common_bin_reset (BinMenu *binmenu)
 {
-	if (binmenu->tmpvalue)
+	if (binmenu->tmpvalue) {
 		gda_value_free (binmenu->tmpvalue);
+		binmenu->tmpvalue = NULL;
+	}
 	if (binmenu->popup)
 		gtk_widget_destroy (binmenu->popup);
 	g_free (binmenu->current_folder);
diff --git a/libgda-ui/gdaui-basic-form.c b/libgda-ui/gdaui-basic-form.c
index 1b131d0..9b4a341 100644
--- a/libgda-ui/gdaui-basic-form.c
+++ b/libgda-ui/gdaui-basic-form.c
@@ -333,11 +333,8 @@ get_rid_of_set (GdaSet *paramlist, GdauiBasicForm *form)
 	}
 
 	/* render all the entries non sensitive */
-	list = form->priv->entries;
-	while (list) {
+	for (list = form->priv->entries; list; list = list->next)
 		gdaui_data_entry_set_editable (GDAUI_DATA_ENTRY (list->data), FALSE);
-		list = g_slist_next (list);
-	}
 }
 
 static void
@@ -1939,18 +1936,15 @@ entry_contents_modified (GdauiDataEntry *entry, GdauiBasicForm *form)
 
 			/* parameter's value */
 			param = GDA_SET_NODE (params->data)->holder;
-			if (gda_holder_set_value (param, (GValue *)(list->data), NULL)) {
+			gda_holder_set_value (param, (GValue *)(list->data), NULL);
 #ifdef debug_signal
-				g_print (">> 'PARAM_CHANGED' from %s\n", __FUNCTION__);
+			g_print (">> 'PARAM_CHANGED' from %s\n", __FUNCTION__);
 #endif
-				g_signal_emit (G_OBJECT (form), gdaui_basic_form_signals[PARAM_CHANGED], 
-					       0, param, TRUE);
+			g_signal_emit (G_OBJECT (form), gdaui_basic_form_signals[PARAM_CHANGED], 
+				       0, param, TRUE);
 #ifdef debug_signal
-				g_print ("<< 'PARAM_CHANGED' from %s\n", __FUNCTION__);
+			g_print ("<< 'PARAM_CHANGED' from %s\n", __FUNCTION__);
 #endif
-			}
-			else
-				TO_IMPLEMENT;
 			form->priv->forward_param_updates = TRUE;
 		}
 		g_slist_free (values);