[gstreamermm] PropertyProbe: Don't take copies of returned wrapped GValueArray.
- From: José Alburquerque <jaalburqu src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [gstreamermm] PropertyProbe: Don't take copies of returned wrapped GValueArray.
- Date: Tue, 6 Oct 2009 03:18:36 +0000 (UTC)
commit 8fbf80f249d895718924ee187e20aa5ff467c7e6
Author: José Alburquerque <jaalburqu svn gnome org>
Date: Mon Oct 5 23:15:09 2009 -0400
PropertyProbe: Don't take copies of returned wrapped GValueArray.
* gstreamer/src/propertyprobe.hg (get_values): Don't take copies of
returned wrapped GValueArray because these are created on the fly by
the class implementing the interface and are not structure members
that would be deleted if a copy is not taken as would happen, for
example, with Gst::Message::get_structure() which returns a wrapped
structure member.
ChangeLog | 11 +++++++++++
gstreamer/src/propertyprobe.hg | 2 +-
2 files changed, 12 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index f0062d5..fb8a321 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2009-10-05 José Alburquerque <jaalburqu svn gnome org>
+
+ PropertyProbe: Don't take copies of returned wrapped GValueArray.
+
+ * gstreamer/src/propertyprobe.hg (get_values): Don't take copies of
+ returned wrapped GValueArray because these are created on the fly by
+ the class implementing the interface and are not structure members
+ that would be deleted if a copy is not taken as would happen, for
+ example, with Gst::Message::get_structure() which returns a wrapped
+ structure member.
+
2009-10-01 José Alburquerque <jaalburqu svn gnome org>
configure.ac: Remove check for patch as it is not needed anymore.
diff --git a/gstreamer/src/propertyprobe.hg b/gstreamer/src/propertyprobe.hg
index f9e72f8..846e545 100644
--- a/gstreamer/src/propertyprobe.hg
+++ b/gstreamer/src/propertyprobe.hg
@@ -44,7 +44,7 @@ public:
_WRAP_METHOD(const GParamSpec* get_property(const Glib::ustring& name) const, gst_property_probe_get_property)
-#m4 _CONVERSION(`GValueArray*', `Glib::ValueArray', `Glib::wrap($3, true)')
+#m4 _CONVERSION(`GValueArray*', `Glib::ValueArray', `Glib::wrap($3)')
_WRAP_METHOD(Glib::ValueArray get_values(const GParamSpec* pspec) const, gst_property_probe_get_values)
_WRAP_METHOD(Glib::ValueArray get_values(const Glib::ustring& name) const, gst_property_probe_get_values_name)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]