[gnome-shell] Don't show all sections each time the search is updated
- From: Marina Zhurakhinskaya <marinaz src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [gnome-shell] Don't show all sections each time the search is updated
- Date: Thu, 1 Oct 2009 22:22:53 +0000 (UTC)
commit abdd8b330cd96f6c9fb7eb63ba5b17a8b71c164e
Author: Marina Zhurakhinskaya <marinaz redhat com>
Date: Thu Oct 1 18:21:27 2009 -0400
Don't show all sections each time the search is updated
We shouldn't show all sections each time the search is updated because that
breaks viewing search results for a single section and flickers headers for
sections with no results.
js/ui/dash.js | 11 ++++-------
1 files changed, 4 insertions(+), 7 deletions(-)
---
diff --git a/js/ui/dash.js b/js/ui/dash.js
index b2686e5..28cd700 100644
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -889,6 +889,9 @@ Dash.prototype = {
_updateDashActors: function() {
if (this._searchPending) {
this._searchResultsSection.actor.show();
+ // We initially hide all sections when we start a search. When the search timeout
+ // first runs, the sections that have matching results are shown. As the search
+ // is refined, only the sections that have matching results will be shown.
for (let i = 0; i < this._searchSections.length; i++) {
let section = this._searchSections[i];
section.header.actor.hide();
@@ -897,13 +900,7 @@ Dash.prototype = {
this._appsSection.actor.hide();
this._placesSection.actor.hide();
this._docsSection.actor.hide();
- } else if (this._searchActive) {
- for (let i = 0; i < this._searchSections.length; i++) {
- let section = this._searchSections[i];
- section.header.actor.show();
- section.resultArea.actor.show();
- }
- } else {
+ } else if (!this._searchActive) {
this._showAllSearchSections();
this._searchResultsSection.actor.hide();
this._appsSection.actor.show();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]