[gnome-python-desktop] Fix crash in gnomekeyringk.item_get_attributes_sync
- From: Vincent Untz <vuntz src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [gnome-python-desktop] Fix crash in gnomekeyringk.item_get_attributes_sync
- Date: Tue, 24 Nov 2009 03:36:08 +0000 (UTC)
commit a01e29f7bfa08a7caa91e257a71097cb712ffdde
Author: Vincent Untz <vuntz gnome org>
Date: Fri Nov 20 15:33:47 2009 -0600
Fix crash in gnomekeyringk.item_get_attributes_sync
This was crashing when requesting attributes from a keyring that doesn't
exist.
https://bugzilla.gnome.org/show_bug.cgi?id=598835
gnomekeyring/gnomekeyring.override | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/gnomekeyring/gnomekeyring.override b/gnomekeyring/gnomekeyring.override
index 85c499a..304cdbc 100644
--- a/gnomekeyring/gnomekeyring.override
+++ b/gnomekeyring/gnomekeyring.override
@@ -296,11 +296,12 @@ _wrap_gnome_keyring_item_get_attributes_sync(PyObject *self, PyObject *args, PyO
ret = gnome_keyring_item_get_attributes_sync(keyring, id, &attrlist);
pyg_end_allow_threads;
+ if (pygnomekeyring_result_check(ret))
+ return NULL;
+
py_attrlist = pygnome_keyring_attribute_list_as_pyobject(attrlist);
if (!py_attrlist)
return NULL;
- if (pygnomekeyring_result_check(ret))
- return NULL;
return py_attrlist;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]