[nautilus-actions: 19/30] Fix dialog title not reset after save
- From: Pierre Wieser <pwieser src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [nautilus-actions: 19/30] Fix dialog title not reset after save
- Date: Sat, 21 Nov 2009 18:02:51 +0000 (UTC)
commit 9d6e20160fba5037068c47c204d5b479473ba385
Author: Pierre Wieser <pwieser trychlos org>
Date: Fri Nov 20 15:59:12 2009 +0100
Fix dialog title not reset after save
When the only modification to be saved was the deletion of a row, then the dialog
title was not correctly reset.
ChangeLog | 7 +++++++
TODO | 2 --
nautilus-actions/nact/nact-main-menubar.c | 2 ++
nautilus-actions/nact/nact-main-window.c | 2 ++
4 files changed, 11 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 75e7872..675950b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -11,6 +11,13 @@
* nautilus-actions/nact/nact-iactions-list.c
(on_treeview_selection_changed): Fix typo.
+ * nautilus-actions/nact/nact-main-menubar.c (on_save_activated):
+ Complete comment about status check.
+
+ * nautilus-actions/nact/nact-main-window.c
+ (nact_main_window_remove_deleted): Setup dialog title is required
+ here when this is the only modification to be saved.
+
2009-11-19 Pierre Wieser <pwieser trychlos org>
Create GConf IO Provider as a plugin.
diff --git a/TODO b/TODO
index ae62884..ae416ea 100644
--- a/TODO
+++ b/TODO
@@ -86,8 +86,6 @@
- na_pivot_new: shouldn't take an argument (use add_consumer)
-- NACT: deleting an action, then saving, doesn't reset modif indicator (*)
-
- gconf monitor doesn't work when creating with nautilus-actions-new
- in 64bits arch, pkglibdir=/lib ??
diff --git a/nautilus-actions/nact/nact-main-menubar.c b/nautilus-actions/nact/nact-main-menubar.c
index c3df99b..517867e 100644
--- a/nautilus-actions/nact/nact-main-menubar.c
+++ b/nautilus-actions/nact/nact-main-menubar.c
@@ -797,6 +797,8 @@ on_save_activated( GtkAction *gtk_action, NactMainWindow *window )
/* recursively save the modified items
* check is useless here if item was not modified, but not very costly
+ * above all, it is cheaper to check the status here, than to check
+ * recursively each and every modified item
*/
for( it = items ; it ; it = it->next ){
save_item( window, pivot, NA_OBJECT_ITEM( it->data ));
diff --git a/nautilus-actions/nact/nact-main-window.c b/nautilus-actions/nact/nact-main-window.c
index 9f69843..58c9132 100644
--- a/nautilus-actions/nact/nact-main-window.c
+++ b/nautilus-actions/nact/nact-main-window.c
@@ -872,6 +872,8 @@ nact_main_window_remove_deleted( NactMainWindow *window )
na_object_free_items_list( window->private->deleted );
window->private->deleted = NULL;
+
+ setup_dialog_title( window );
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]