[totem] Fix double-free in the Cone plugin's playlist



commit 03addbe4c6741245472787ba54cde0474120644c
Author: Bastien Nocera <hadess hadess net>
Date:   Fri Nov 20 16:16:28 2009 +0000

    Fix double-free in the Cone plugin's playlist

 browser-plugin/totemConePlaylist.cpp |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/browser-plugin/totemConePlaylist.cpp b/browser-plugin/totemConePlaylist.cpp
index d5854d3..cd306fd 100644
--- a/browser-plugin/totemConePlaylist.cpp
+++ b/browser-plugin/totemConePlaylist.cpp
@@ -95,22 +95,21 @@ totemConePlaylist::InvokeByIndex (int aIndex,
 
         str = g_strndup (options.UTF8Characters, options.UTF8Length);
         items = g_strsplit (str, " ", -1);
+        g_free (str);
 
         for (i = 0; items[i] != NULL; i++) {
           if (g_str_has_prefix (items[i], ":sub-file=")) {
             subtitle = g_strdup (items[i] + strlen (":sub-file="));
-            g_strfreev (items);
-            g_free (str);
 	    break;
 	  }
 	}
 	g_strfreev (items);
-	g_free (str);
       }
 
       Plugin()->AddItem (mrl, title, subtitle);
       g_free (subtitle);
-      return Int32Variant (_result, 0);
+      //FIXME we're supposed to return a unique number here
+      return Int32Variant (_result, 1);
     }
 
     case ePlay:



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]