[gimp-gap] fixed a bug in the storyboard clip properties



commit b73a032cee65775473946a47fbbfd37c06e9baa1
Author: Wolfgang Hofer <wolfgangh svn gnome org>
Date:   Thu Nov 19 19:29:15 2009 +0100

    fixed a bug in the storyboard clip properties

 ChangeLog                  |   10 ++++++++++
 gap/gap_story_properties.c |    9 ++++++++-
 2 files changed, 18 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 1b768ad..230d858 100755
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2009-11-19 Wolfgang Hofer <hof gimp org>   UNCOMMITED
+
+ - fixed a bug in the storyboard clip properties
+   that removed masks from video clips when the properties popup dialog was closed and opend again.
+   an active_index -1 in the combo box inidcates empty combo box (typic while widget creation)
+   and must NOT trigger removal of the mask (this is restricted to selection of the "None" entry with index 0
+   or in case entries are present but none is matching the list of valid mask names)
+
+  * gap/gap_story_properties.c
+
 2009-08-11 Wolfgang Hofer <hof gimp org>
 
 - detection of videofiles by extension now also accepts.mp4 videos.
diff --git a/gap/gap_story_properties.c b/gap/gap_story_properties.c
index 3454aee..c3e2d6a 100644
--- a/gap/gap_story_properties.c
+++ b/gap/gap_story_properties.c
@@ -2195,7 +2195,14 @@ p_pw_mask_name_combo_changed_cb( GtkWidget     *widget
     }
   }
 
-  p_pw_mask_name_reference_update(pw, selected_mask_name);
+  /* an active_index -1 indicates that the combo box has no entries
+   * (this can occur during the widget is built and shall not
+   * remove an existing mask_name)
+   */
+  if (active_index >= 0)
+  {
+    p_pw_mask_name_reference_update(pw, selected_mask_name);
+  }
 
 }  /* end p_pw_mask_name_combo_changed_cb */
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]