[gnome-shell] [dash] Convert pane close to St.Button, avoiding release event propagation



commit fec2ea5e9c0e0cc78d6238a951fe520a3347a1c1
Author: Colin Walters <walters verbum org>
Date:   Thu Nov 12 13:09:20 2009 -0500

    [dash] Convert pane close to St.Button, avoiding release event propagation
    
    The workspaces was handling the release event after closing the pane,
    catch it before closing by using St.Button.

 js/ui/dash.js |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/dash.js b/js/ui/dash.js
index fd5d947..3398fce 100644
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -94,11 +94,9 @@ Pane.prototype = {
 
         let chromeTop = new St.BoxLayout();
 
-        let closeIcon = new St.Bin({ style_class: "dash-pane-close" });
-        closeIcon.reactive = true;
-        closeIcon.connect('button-press-event', Lang.bind(this, function (b, e) {
+        let closeIcon = new St.Button({ style_class: "dash-pane-close" });
+        closeIcon.connect('clicked', Lang.bind(this, function (b, e) {
             this.close();
-            return true;
         }));
         let dummy = new St.Bin();
         chromeTop.add(dummy, { expand: true });



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]