[splinter] Fix problem with private attachments
- From: Owen Taylor <otaylor src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [splinter] Fix problem with private attachments
- Date: Sat, 7 Nov 2009 23:19:35 +0000 (UTC)
commit e4edbe4f8280156e27f8a5b0d76a07c607c56869
Author: Owen W. Taylor <otaylor fishsoup net>
Date: Sat Nov 7 18:18:13 2009 -0500
Fix problem with private attachments
Fix problem where when checking access rights to a private
attachment an undefined variable $user was being accessed.
https://bugzilla.gnome.org/show_bug.cgi?id=601118
extension/lib/SplinterUtil.pm | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/extension/lib/SplinterUtil.pm b/extension/lib/SplinterUtil.pm
index 80c11dd..313f64e 100644
--- a/extension/lib/SplinterUtil.pm
+++ b/extension/lib/SplinterUtil.pm
@@ -36,8 +36,8 @@ sub attachment_is_visible {
return (Bugzilla->user->can_see_bug($attachment->bug->id) &&
(!$attachment->isprivate ||
- $user->id == $attachment->attacher->id ||
- $user->is_insider));
+ Bugzilla->user->id == $attachment->attacher->id ||
+ Bugzilla->user->is_insider));
}
sub attachment_id_is_patch {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]