[gnumeric] solver: fix _get_input_cells.



commit d04f051c86127c7d254f6b992bbbc4be6accb35d
Author: Morten Welinder <terra gnome org>
Date:   Mon Nov 2 19:57:59 2009 -0500

    solver: fix _get_input_cells.

 src/dialogs/ChangeLog       |    4 ++++
 src/dialogs/dialog-solver.c |    3 ++-
 src/tools/solver/ChangeLog  |    4 ++++
 src/tools/solver/solver.c   |    2 +-
 4 files changed, 11 insertions(+), 2 deletions(-)
---
diff --git a/src/dialogs/ChangeLog b/src/dialogs/ChangeLog
index a807688..f25d610 100644
--- a/src/dialogs/ChangeLog
+++ b/src/dialogs/ChangeLog
@@ -1,3 +1,7 @@
+2009-11-02  Morten Welinder  <terra gnome org>
+
+	* dialog-solver.c (cb_dialog_solver_destroy): Plug leak.
+
 2009-11-02  Andreas J. Guelzow <aguelzow pyrshep ca>
 
 	* dialogs.h: remove dialog_autocorrect
diff --git a/src/dialogs/dialog-solver.c b/src/dialogs/dialog-solver.c
index d765777..f8c9e4b 100644
--- a/src/dialogs/dialog-solver.c
+++ b/src/dialogs/dialog-solver.c
@@ -360,7 +360,8 @@ cb_dialog_solver_destroy (SolverState *state)
 		go_slist_free_custom (state->ov_stack,
 				      (GFreeFunc)free_original_values);
 		state->ov_stack = NULL;
-		g_slist_free (state->ov_cell_stack);
+		go_slist_free_custom (state->ov_cell_stack,
+				      (GFreeFunc)g_slist_free);
 		state->ov_cell_stack = NULL;
 	}
 
diff --git a/src/tools/solver/ChangeLog b/src/tools/solver/ChangeLog
index d74cee8..34fc58f 100644
--- a/src/tools/solver/ChangeLog
+++ b/src/tools/solver/ChangeLog
@@ -1,3 +1,7 @@
+2009-11-02  Morten Welinder  <terra gnome org>
+
+	* solver.c (gnm_solver_param_get_input_cells): Fix crash.
+
 2009-11-01  Morten Welinder <terra gnome org>
 
 	* Release 1.9.15
diff --git a/src/tools/solver/solver.c b/src/tools/solver/solver.c
index 6cb5af4..7eda6b0 100644
--- a/src/tools/solver/solver.c
+++ b/src/tools/solver/solver.c
@@ -140,7 +140,7 @@ gnm_solver_param_get_input_cells (SolverParameters const *sp)
 	eval_pos_init_sheet (&ep, sp->sheet);
 	workbook_foreach_cell_in_range (&ep, vr, CELL_ITER_ALL,
 					cb_grab_cells,
-					input_cells);
+					&input_cells);
 	return input_cells;
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]