[eog] Bug 583448 – Crash on exif data

[Felix Riemann <friemann src gnome org>]

commit 4730359e7547520fbcbd78e690e83958a00f7341
Author: Felix Riemann <friemann svn gnome org>
Date:   Fri May 22 12:39:09 2009 +0200

    Bug 583448 â?? Crash on exif data
    
    Secure Exif data updating with a mutex. Should fix crashes when
    reading the Exif block during the update. This was made visible be the
    leak fix from commit cb1e01983a6b273ba65b57449e5ab5f13c448658 .
---
 ChangeLog       |    6 ++++++
 src/eog-image.c |    2 ++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fb611c6..06db2b3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-05-22  Felix Riemann  <friemann svn gnome org>
+
+	* src/eog-image.c (eog_image_set_exif_data):
+	Secure Exif data updating with a mutex. Should fix crashes when
+	reading the Exif block during the update. Fixes bug #583448.
+
 2009-05-20  Felix Riemann  <friemann svn gnome org>
 
 	* data/eog-image-properties-dialog.glade:
diff --git a/src/eog-image.c b/src/eog-image.c
index a02ca82..ff812d2 100644
--- a/src/eog-image.c
+++ b/src/eog-image.c
@@ -754,10 +754,12 @@ eog_image_set_exif_data (EogImage *img, EogMetadataReader *md_reader)
 	priv = img->priv;
 
 #ifdef HAVE_EXIF
+	g_mutex_lock (priv->status_mutex);
 	if (priv->exif) {
 		exif_data_unref (priv->exif);
 	}
 	priv->exif = eog_metadata_reader_get_exif_data (md_reader);
+	g_mutex_unlock (priv->status_mutex);
 
 	priv->exif_chunk = NULL;
 	priv->exif_chunk_len = 0;