[valadoc] - Fix many valac warnings.

[Florian Brosch <flobrosch src gnome org>]

commit a00be443d736d3c1274c474be659ad1fe67d51c0
Author: Florian Brosch <flo brosch gmail com>
Date:   Tue May 19 02:56:33 2009 +0200

    - Fix many valac warnings.
---
 configure.in                                       |   69 +++++++-------------
 src/doclets/devhelp/doclet/doclet.vala             |    2 +-
 src/doclets/htmlhelpers/taglets/link/taglet.vala   |    4 +-
 src/doclets/htmlhelpers/taglets/source/taglet.vala |    4 +-
 src/libvaladoc/doctree.vala                        |    6 +-
 src/libvaladoc/parser.vala                         |    2 +-
 6 files changed, 32 insertions(+), 55 deletions(-)

diff --git a/configure.in b/configure.in
index 7e9c053..1ce90c0 100644
--- a/configure.in
+++ b/configure.in
@@ -59,7 +59,6 @@ AC_SUBST(LIBVALA_LIBS)
 
 
 
-
 # Checks for header files.
 
 # Checks for typedefs, structures, and compiler characteristics.
@@ -74,57 +73,35 @@ AC_CONFIG_FILES([Makefile
                  src/vapi/Makefile
                  src/doclets/Makefile
                  src/doclets/htmlhelpers/Makefile
+                 src/doclets/htmlhelpers/deps/Makefile
+                 src/doclets/htmlhelpers/doclet/Makefile
+                 src/doclets/htmlhelpers/taglets/Makefile
+                 src/doclets/htmlhelpers/taglets/see/Makefile
+                 src/doclets/htmlhelpers/taglets/link/Makefile
+                 src/doclets/htmlhelpers/taglets/list/Makefile
+                 src/doclets/htmlhelpers/taglets/bold/Makefile
+                 src/doclets/htmlhelpers/taglets/since/Makefile
+                 src/doclets/htmlhelpers/taglets/table/Makefile
+                 src/doclets/htmlhelpers/taglets/right/Makefile
+                 src/doclets/htmlhelpers/taglets/image/Makefile
+                 src/doclets/htmlhelpers/taglets/throws/Makefile
+                 src/doclets/htmlhelpers/taglets/string/Makefile
+                 src/doclets/htmlhelpers/taglets/center/Makefile
+                 src/doclets/htmlhelpers/taglets/italic/Makefile
+                 src/doclets/htmlhelpers/taglets/return/Makefile
+                 src/doclets/htmlhelpers/taglets/source/Makefile
+                 src/doclets/htmlhelpers/taglets/typelink/Makefile
+                 src/doclets/htmlhelpers/taglets/underline/Makefile
+                 src/doclets/htmlhelpers/taglets/parameter/Makefile
+                 src/doclets/htmlhelpers/taglets/tablecell/Makefile
+                 src/doclets/htmlhelpers/taglets/listelement/Makefile
+                 src/doclets/htmlhelpers/taglets/notification/Makefile
                  src/doclets/htm/Makefile
                  src/doclets/htm/doclet/Makefile
-                 src/doclets/htm/deps/Makefile
-                 src/doclets/htm/taglets/Makefile
-                 src/doclets/htm/taglets/parameter/Makefile
-                 src/doclets/htm/taglets/version/Makefile
-                 src/doclets/htm/taglets/throws/Makefile
-                 src/doclets/htm/taglets/return/Makefile
-                 src/doclets/htm/taglets/string/Makefile
-                 src/doclets/htm/taglets/wikilink/Makefile
-                 src/doclets/htm/taglets/image/Makefile
-                 src/doclets/htm/taglets/link/Makefile
-                 src/doclets/htm/taglets/center/Makefile
-                 src/doclets/htm/taglets/right/Makefile
-                 src/doclets/htm/taglets/italic/Makefile
-                 src/doclets/htm/taglets/source/Makefile
-                 src/doclets/htm/taglets/bold/Makefile
-                 src/doclets/htm/taglets/underline/Makefile
-                 src/doclets/htm/taglets/notification/Makefile
-                 src/doclets/htm/taglets/see/Makefile
-                 src/doclets/htm/taglets/table/Makefile
-                 src/doclets/htm/taglets/list/Makefile
-                 src/doclets/htm/taglets/listelement/Makefile
-                 src/doclets/htm/taglets/cell/Makefile
                  src/doclets/valadoc.org/Makefile
                  src/doclets/valadoc.org/doclet/Makefile
                  src/doclets/devhelp/Makefile
-                 src/doclets/devhelp/taglets/image/Makefile
-                 src/doclets/devhelp/taglets/notification/Makefile
-                 src/doclets/devhelp/taglets/italic/Makefile
-                 src/doclets/devhelp/taglets/center/Makefile
-                 src/doclets/devhelp/taglets/right/Makefile
-                 src/doclets/devhelp/taglets/bold/Makefile
-                 src/doclets/devhelp/taglets/underline/Makefile
-                 src/doclets/devhelp/taglets/list/Makefile
-                 src/doclets/devhelp/taglets/listelement/Makefile
-                 src/doclets/devhelp/taglets/table/Makefile
-                 src/doclets/devhelp/taglets/cell/Makefile
-                 src/doclets/devhelp/taglets/source/Makefile
-                 src/doclets/devhelp/deps/Makefile
                  src/doclets/devhelp/doclet/Makefile
-                 src/doclets/devhelp/taglets/Makefile
-                 src/doclets/devhelp/taglets/parameter/Makefile
-                 src/doclets/devhelp/taglets/version/Makefile
-                 src/doclets/devhelp/taglets/throws/Makefile
-                 src/doclets/devhelp/taglets/wikilink/Makefile
-                 src/doclets/devhelp/taglets/return/Makefile
-                 src/doclets/devhelp/taglets/string/Makefile
-                 src/doclets/devhelp/taglets/link/Makefile
-                 src/doclets/devhelp/taglets/see/Makefile
                  src/valadoc/Makefile])
 
-
 AC_OUTPUT
diff --git a/src/doclets/devhelp/doclet/doclet.vala b/src/doclets/devhelp/doclet/doclet.vala
index 36eb06d..9c0614c 100644
--- a/src/doclets/devhelp/doclet/doclet.vala
+++ b/src/doclets/devhelp/doclet/doclet.vala
@@ -136,7 +136,7 @@ public class Valadoc.Devhelp.Doclet : Valadoc.Html.BasicDoclet {
 	public override void initialisation ( Settings settings, Tree tree ) {
 		this.settings = settings;
 
-		var rt = DirUtils.create ( this.settings.path, 0777 );
+		DirUtils.create ( this.settings.path, 0777 );
 
 		this.langlet = new Valadoc.Html.BasicLanglet ( settings );
 		this.devhelp = new DevhelpFormat ( settings.pkg_name, "" );
diff --git a/src/doclets/htmlhelpers/taglets/link/taglet.vala b/src/doclets/htmlhelpers/taglets/link/taglet.vala
index bac58bd..f6da5d5 100755
--- a/src/doclets/htmlhelpers/taglets/link/taglet.vala
+++ b/src/doclets/htmlhelpers/taglets/link/taglet.vala
@@ -28,8 +28,8 @@ namespace Valadoc.Html {
 		protected Gee.ArrayList<DocElement>? desc;
 		protected string path;
 
-		public override bool parse ( Settings settings, Tree tree, DocumentedElement me, string# path, Gee.ArrayList<DocElement>? desc ) {
-			this.path = #path;
+		public override bool parse ( Settings settings, Tree tree, DocumentedElement me, owned string path, Gee.ArrayList<DocElement>? desc ) {
+			this.path = (owned)path;
 			this.desc = desc;
 			return true;
 		}
diff --git a/src/doclets/htmlhelpers/taglets/source/taglet.vala b/src/doclets/htmlhelpers/taglets/source/taglet.vala
index d290eeb..eae98e8 100755
--- a/src/doclets/htmlhelpers/taglets/source/taglet.vala
+++ b/src/doclets/htmlhelpers/taglets/source/taglet.vala
@@ -34,9 +34,9 @@ namespace Valadoc.Html {
 			get;
 		}
 
-		public override bool parse ( Settings settings, Tree tree, DocumentedElement me, string# src, Language lang ) {
+		public override bool parse ( Settings settings, Tree tree, DocumentedElement me, owned string src, Language lang ) {
 			this.lang = lang;
-			this.src = #src;
+			this.src = (owned)src;
 			return true;
 		}
 
diff --git a/src/libvaladoc/doctree.vala b/src/libvaladoc/doctree.vala
index 71aac12..88d95b5 100644
--- a/src/libvaladoc/doctree.vala
+++ b/src/libvaladoc/doctree.vala
@@ -117,15 +117,15 @@ public abstract class Valadoc.StringTaglet : Taglet {
 }
 
 public abstract class Valadoc.ImageDocElement : DocElement {
-	public abstract bool parse ( Settings settings, Tree tree, DocumentedElement me, string# path, ImageDocElementPosition pos );
+	public abstract bool parse ( Settings settings, Tree tree, DocumentedElement me, owned string path, ImageDocElementPosition pos );
 }
 
 public abstract class Valadoc.LinkDocElement : DocElement {
-	public abstract bool parse ( Settings settings, Tree tree, DocumentedElement me, string# link, Gee.ArrayList<DocElement>? desc );
+	public abstract bool parse ( Settings settings, Tree tree, DocumentedElement me, owned string link, Gee.ArrayList<DocElement>? desc );
 }
 
 public abstract class Valadoc.SourceCodeDocElement : DocElement {
-	public abstract bool parse ( Settings settings, Tree tree, DocumentedElement me, string# src, Language lang );
+	public abstract bool parse ( Settings settings, Tree tree, DocumentedElement me, owned string src, Language lang );
 }
 
 public abstract class Valadoc.ListEntryDocElement : DocElement {
diff --git a/src/libvaladoc/parser.vala b/src/libvaladoc/parser.vala
index 6ca1e7c..cd9b4b3 100644
--- a/src/libvaladoc/parser.vala
+++ b/src/libvaladoc/parser.vala
@@ -1182,7 +1182,7 @@ public class Valadoc.Parser {
 
 						content = new Gee.ArrayList<DocElement> ();
 						curtag = create_main_taglet ( name );
-						curtagname = #name;
+						curtagname = (owned)name;
 						break;
 					case '#':
 						this.append_and_create_string_taglet ( content, tree, me, buf );