[gtksourceview] Safely printf strings



commit 4a09b43f9b03ab0639f34e00278bd631a08bc8be
Author: Christian Persch <chpe gnome org>
Date:   Thu May 7 14:14:13 2009 +0200

    Safely printf strings
    
    Bug #581734.
---
 gtksourceview/gtksourcecontextengine.c |    2 +-
 gtksourceview/gtksourceview-i18n.h     |    4 ++--
 tests/test-widget.c                    |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gtksourceview/gtksourcecontextengine.c b/gtksourceview/gtksourcecontextengine.c
index 4cf04b7..b649665 100644
--- a/gtksourceview/gtksourcecontextengine.c
+++ b/gtksourceview/gtksourcecontextengine.c
@@ -2605,7 +2605,7 @@ regex_new (const gchar           *pattern,
 	{
 		g_set_error (error, GTK_SOURCE_CONTEXT_ENGINE_ERROR,
 			     GTK_SOURCE_CONTEXT_ENGINE_ERROR_INVALID_REGEX,
-			     _("using \\C is not supported in language definitions"));
+			     "%s", _("using \\C is not supported in language definitions"));
 		return NULL;
 	}
 
diff --git a/gtksourceview/gtksourceview-i18n.h b/gtksourceview/gtksourceview-i18n.h
index fb6470d..c7f269d 100644
--- a/gtksourceview/gtksourceview-i18n.h
+++ b/gtksourceview/gtksourceview-i18n.h
@@ -71,9 +71,9 @@ G_BEGIN_DECLS
 #    define GD_(Domain,String) (g_strdup (String))
 #endif
 
-char *_gtksourceview_gettext (const char *msgid);
+char *_gtksourceview_gettext (const char *msgid) G_GNUC_FORMAT(1);
 /* NOTE: it returns duplicated string */
-char *_gtksourceview_dgettext (const char *domain, const char *msgid);
+char *_gtksourceview_dgettext (const char *domain, const char *msgid) G_GNUC_FORMAT(2);
 
 G_END_DECLS
 
diff --git a/tests/test-widget.c b/tests/test-widget.c
index 312f7a7..7cbb85e 100644
--- a/tests/test-widget.c
+++ b/tests/test-widget.c
@@ -261,7 +261,7 @@ error_dialog (GtkWindow *parent, const gchar *msg, ...)
 					 GTK_DIALOG_DESTROY_WITH_PARENT,
 					 GTK_MESSAGE_ERROR,
 					 GTK_BUTTONS_OK,
-					 tmp);
+					 "%s", tmp);
 	g_free (tmp);
 
 	gtk_dialog_run (GTK_DIALOG (dialog));



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]