[gnumeric] Undo fix for 581117. It's not right. Bug now hidden by later changes.



commit 870de5ff37a43f00120f60d58e3846c01ddff1a2
Author: Morten Welinder <terra gnome org>
Date:   Sun May 3 20:31:52 2009 -0400

    Undo fix for 581117.  It's not right.  Bug now hidden by later changes.
---
 ChangeLog       |    3 +++
 src/expr-name.c |   23 +----------------------
 2 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d5788af..3fcfd90 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2009-05-03  Morten Welinder  <terra gnome org>
 
+	* src/expr-name.c (expr_name_handle_references): Undo last change.
+	Bug 581117 is duct taped by sheet_get_nominal_printarea change.
+
 	* src/sheet.c (sheet_get_nominal_printarea): Work harder at
 	ensuring sanity.
 
diff --git a/src/expr-name.c b/src/expr-name.c
index e412e3b..dab15ee 100644
--- a/src/expr-name.c
+++ b/src/expr-name.c
@@ -321,33 +321,12 @@ expr_name_handle_references (GnmNamedExpr *nexpr, gboolean add)
 	GSList *sheets, *ptr;
 
 	sheets = gnm_expr_top_referenced_sheets (nexpr->texpr);
-	if (g_slist_find (sheets, NULL)) {
-		/* The value has a sheet-less references.  */
-		Sheet *base_sheet = nexpr->pos.sheet;
-		if (base_sheet) {
-			if (!g_slist_find (sheets, base_sheet))
-				sheets = g_slist_prepend (sheets, base_sheet);
-		} else {
-			/*
-			 * A global name.  Might reference any sheet in the
-			 * workbook it is defined.  FIXME: What if we add
-			 * sheets later?
-			 */
-			GSList *l, *wb_sheets = workbook_sheets (nexpr->pos.wb);
-			for (l = wb_sheets; l; l = l->next) {
-				Sheet *sheet = l->data;
-				if (!g_slist_find (sheets, sheet))
-					sheets = g_slist_prepend (sheets, sheet);
-			}
-			g_slist_free (wb_sheets);
-		}
-	}
 
 	for (ptr = sheets ; ptr != NULL ; ptr = ptr->next) {
 		Sheet *sheet = ptr->data;
 		GnmNamedExpr *found;
 
-		/* Handled above.  */
+		/* Implicit reference.  */
 		if (!sheet)
 			continue;
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]