[totem-pl-parser] Bug 576338 – video title says "get_video" instead of video name



commit ba31e1e714c4c2a5e256e7b8127526cceb28213f
Author: Bastien Nocera <hadess hadess net>
Date:   Sun May 3 02:16:09 2009 +0100

    Bug 576338 â?? video title says "get_video" instead of video name
    
    2009-05-03  Bastien Nocera  <hadess hadess net>
    
    	* plparse/totem-pl-parser-qt.c (totem_pl_parser_add_quicktime):
    	Don't implement a fall-back when the top-level parsing code
    	can already do that for us, and we might not want a fall-back.
    	Fixes video/mp4 files played from YouTube showing up with
    	"get_video" as the video name (Closes: #576338)
---
 ChangeLog                    |    8 ++++++++
 plparse/totem-pl-parser-qt.c |   10 ++--------
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 45358e9..52f3cc2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-05-03  Bastien Nocera  <hadess hadess net>
+
+	* plparse/totem-pl-parser-qt.c (totem_pl_parser_add_quicktime):
+	Don't implement a fall-back when the top-level parsing code
+	can already do that for us, and we might not want a fall-back.
+	Fixes video/mp4 files played from YouTube showing up with
+	"get_video" as the video name (Closes: #576338)
+
 2009-04-29  Bastien Nocera  <hadess hadess net>
 
 	* plparse/tests/parser.c (test_parsability): Add test cases for
diff --git a/plparse/totem-pl-parser-qt.c b/plparse/totem-pl-parser-qt.c
index ef9147e..03b5311 100644
--- a/plparse/totem-pl-parser-qt.c
+++ b/plparse/totem-pl-parser-qt.c
@@ -202,14 +202,8 @@ totem_pl_parser_add_quicktime (TotemPlParser *parser,
 			       GFile *base_file,
 			       gpointer data)
 {
-	if (data == NULL || totem_pl_parser_is_quicktime (data, strlen (data)) == NULL) {
-		char *uri;
-
-		uri = g_file_get_uri (file);
-		totem_pl_parser_add_one_uri (parser, uri, NULL);
-		g_free (uri);
-		return TOTEM_PL_PARSER_RESULT_SUCCESS;
-	}
+	if (data == NULL || totem_pl_parser_is_quicktime (data, strlen (data)) == NULL)
+		return TOTEM_PL_PARSER_RESULT_UNHANDLED;
 
 	return totem_pl_parser_add_quicktime_metalink (parser, file, base_file, data);
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]