glade3 r2177 - in trunk: . gladeui



Author: tvb
Date: Mon Mar 23 00:48:29 2009
New Revision: 2177
URL: http://svn.gnome.org/viewvc/glade3?rev=2177&view=rev

Log:

	* gladeui/glade-widget.c: Fix broken hash table maintenence in 
	glade_widget_remove_property() (bug 575885).



Modified:
   trunk/ChangeLog
   trunk/gladeui/glade-widget.c

Modified: trunk/gladeui/glade-widget.c
==============================================================================
--- trunk/gladeui/glade-widget.c	(original)
+++ trunk/gladeui/glade-widget.c	Mon Mar 23 00:48:29 2009
@@ -622,9 +622,14 @@
 	g_return_if_fail (GLADE_IS_WIDGET (widget));
 	g_return_if_fail (id_property);
 
+	/* XXX FIXME: currently we arent calling this on packing properties,
+	 * but doing so could cause crashes because the hash table is not
+	 * managed properly
+	 */
 	if ((prop = glade_widget_get_property (widget, id_property)) != NULL)
 	{
 		widget->properties = g_list_remove (widget->properties, prop);
+		g_hash_table_remove (widget->props_hash, prop->klass->id);
 		g_object_unref (prop);
 	}
 	else



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]