gnumeric r17199 - in trunk: . plugins/excel



Author: mortenw
Date: Sat Mar 14 14:00:34 2009
New Revision: 17199
URL: http://svn.gnome.org/viewvc/gnumeric?rev=17199&view=rev

Log:
	(cb_NOTE_v8): If there is no author, just use the empty string.



Modified:
   trunk/NEWS
   trunk/plugins/excel/ChangeLog
   trunk/plugins/excel/ms-excel-write.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Sat Mar 14 14:00:34 2009
@@ -29,6 +29,7 @@
 	* Fix lotus importer crash.  [#575190]
 	* Improve entry of date for locales not using slashes.  [Part of #33229]
 	* Fix xls writing crash.  [Part of #575318]
+	* Fix criticals in xls export for comments without author.
 
 Sum1:
 	* Implement OOO probing.  [#574381]

Modified: trunk/plugins/excel/ms-excel-write.c
==============================================================================
--- trunk/plugins/excel/ms-excel-write.c	(original)
+++ trunk/plugins/excel/ms-excel-write.c	Sat Mar 14 14:00:34 2009
@@ -4788,9 +4788,12 @@
 cb_NOTE_v8 (SheetObject const *so, gconstpointer id, BiffPut *bp)
 {
 	SheetObjectAnchor const *anchor = sheet_object_get_anchor (so);
-	char const  *author = cell_comment_author_get (CELL_COMMENT (so));
+	char const *author = cell_comment_author_get (CELL_COMMENT (so));
 	guint8 buf [4 * 2];
 
+	if (!author)
+		author = "";
+
 	ms_biff_put_var_next (bp,  BIFF_NOTE);
 	GSF_LE_SET_GUINT16 (buf + 0, anchor->cell_bound.start.row);
 	GSF_LE_SET_GUINT16 (buf + 2, anchor->cell_bound.start.col);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]