[nemiver: 1/3] Improve global variable listing (Bug #573709)



commit fb6d357e527a6fb01d4b48122fdfe303c4312419
Author: Jonathon Jongsma <jonathon jongsma collabora co uk>
Date:   Wed Mar 4 00:23:19 2009 -0600

    Improve global variable listing (Bug #573709)
    
    	* src/dbgengine/nmv-gdb-engine.cc: Don't increment oobr_it upon entering the
    	  fetch_variable: label, rather require that the iterator is incremented
    	  before entering the label.  Previously, when dropping into the
    	  fetch_variable label from above, the oobr_it iterator was not incremented,
    	  but when jumping ot the fetch_variable label (from line 3507), the
    	  iterator was already pre-incremented, which resulted in skipped variables.
    	  With this patch, I do get some global variables to show up in the list,
    	  but not all of them, so there are likely other problems lurking still
    	  related to global variable listing.
---
 src/dbgengine/nmv-gdb-engine.cc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/dbgengine/nmv-gdb-engine.cc b/src/dbgengine/nmv-gdb-engine.cc
index 82a1624..6531178 100644
--- a/src/dbgengine/nmv-gdb-engine.cc
+++ b/src/dbgengine/nmv-gdb-engine.cc
@@ -3437,12 +3437,12 @@ fetch_file:
     file_name.chomp ();
     file_name.erase (file_name.length ()-1, 1);
     THROW_IF_FAIL (!file_name.empty ());
+    ++oobr_it;
 
 fetch_variable:
     found = false;
     //we are looking for a string that end's up with a ";\n"
-    for (++oobr_it;
-         oobr_it != a_output.out_of_band_records ().end ();
+    for (; oobr_it != a_output.out_of_band_records ().end ();
          ++oobr_it) {
         if (!oobr_it->has_stream_record ()) {continue;}
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]