epiphany r8851 - in trunk/embed: . webkit

[xan svn gnome org]

Author: xan
Date: Thu Mar  5 07:37:16 2009
New Revision: 8851
URL: http://svn.gnome.org/viewvc/epiphany?rev=8851&view=rev

Log:
Fix a few compiler warnings and coding style.

Modified:
   trunk/embed/downloader-view.c
   trunk/embed/webkit/webkit-embed.c

Modified: trunk/embed/downloader-view.c
==============================================================================
--- trunk/embed/downloader-view.c	(original)
+++ trunk/embed/downloader-view.c	Thu Mar  5 07:37:16 2009
@@ -398,6 +398,7 @@
 	gint64 total, cur;
 	gdouble elapsed_time;
 	gdouble remaining_time;
+	gdouble per_byte_time;
 
 	total = webkit_download_get_total_size (download);
 	cur = webkit_download_get_current_size (download);
@@ -408,7 +409,6 @@
 		return -1.0;
 	}
 
-	gdouble per_byte_time;
 	per_byte_time = elapsed_time / cur;
 	remaining_time = per_byte_time * (total - cur);
 

Modified: trunk/embed/webkit/webkit-embed.c
==============================================================================
--- trunk/embed/webkit/webkit-embed.c	(original)
+++ trunk/embed/webkit/webkit-embed.c	Thu Mar  5 07:37:16 2009
@@ -389,34 +389,37 @@
                        WebKitEmbed *embed)
 {
   EphyFileChooser *dialog;
-
-  GtkWindow *window;
-
+  GtkWidget *window;
   gint dialog_result;
   gboolean handled = FALSE;
 
-  /* Try to get the toplevel window related to the WebView that caused the
-   * download, and use NULL otherwise; we don't want to pass the WebView
-   * or other widget as a parent window.
+  /* 
+   * Try to get the toplevel window related to the WebView that caused
+   * the download, and use NULL otherwise; we don't want to pass the
+   * WebView or other widget as a parent window.
    */
   window = gtk_widget_get_toplevel (GTK_WIDGET(web_view));
   if (!GTK_WIDGET_TOPLEVEL (window))
     window = NULL;
 
   dialog = ephy_file_chooser_new (_("Save"),
-                                  window ? GTK_WIDGET (window) : NULL,
+                                  window ? window : NULL,
                                   GTK_FILE_CHOOSER_ACTION_SAVE,
                                   CONF_STATE_SAVE_DIR,
                                   EPHY_FILE_FILTER_ALL_SUPPORTED);
   gtk_file_chooser_set_do_overwrite_confirmation (GTK_FILE_CHOOSER (dialog), TRUE);
-  
   gtk_file_chooser_set_current_name (GTK_FILE_CHOOSER (dialog),
                                      webkit_download_get_suggested_filename (download));
 
+  /* 
+   * FIXME: agh! gtk_dialog_run. By default the download is cancelled
+   * if we return FALSE, so I think we should just return TRUE always
+   * here and cancel the download ourselves if the user does click
+   * Cancel
+   */
   dialog_result = gtk_dialog_run (GTK_DIALOG (dialog));
 
-  if (dialog_result == GTK_RESPONSE_ACCEPT)
-  {
+  if (dialog_result == GTK_RESPONSE_ACCEPT) {
     DownloaderView *dview;
     char *uri;