[f-spot] Add -warnaserror to assemblies that compile correctly.
- From: Ruben Vermeersch <rubenv src gnome org>
- To: svn-commits-list gnome org
- Subject: [f-spot] Add -warnaserror to assemblies that compile correctly.
- Date: Sun, 28 Jun 2009 15:39:08 +0000 (UTC)
commit cc7d5c30e9b328773afe3c6d10eabe6477647e02
Author: Ruben Vermeersch <ruben savanne be>
Date: Sun Jun 28 17:35:51 2009 +0200
Add -warnaserror to assemblies that compile correctly.
All these warnings hide real errors, added -warnaserrors to the
assemblies that are error free, to prevent new ones from popping up. If
you introduce one, fix it!
src/Bling/Animation.cs | 3 +++
src/Makefile.am | 13 +++++++------
2 files changed, 10 insertions(+), 6 deletions(-)
---
diff --git a/src/Bling/Animation.cs b/src/Bling/Animation.cs
index 2aef972..b0bc236 100644
--- a/src/Bling/Animation.cs
+++ b/src/Bling/Animation.cs
@@ -131,7 +131,10 @@ namespace FSpot.Bling
protected abstract T Interpolate (T from, T to, double progress);
+// Do not error out on this not being used
+#pragma warning disable 67
public event EventHandler Completed;
+#pragma warning restore 67
public event EventHandler<ProgressChangedEventArgs> ProgressChanged;
public bool IsRunning {
diff --git a/src/Makefile.am b/src/Makefile.am
index dd90c7a..97bf342 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,6 +1,7 @@
include $(top_srcdir)/Makefile.include
UNSAFE = -unsafe
NOWARN = -nowarn:0169 -nowarn:0612 -nowarn:0414
+WARNASERROR = -warnaserror
EXTRAFLAGS = -d:TEST_METADATA -d:BROKEN_RSVG -d:GSD_2_24 $(CSC_DEFINES)
CMS_CSDISTFILES = \
@@ -450,15 +451,15 @@ F_SPOT_CSFILES = $(F_SPOT_CSDISTFILES) \
Cms.dll: $(CMS_CSFILES)
@echo -e "\n*** Compiling $@"
- $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(UNSAFE) $(CMS_CSFILES) $(CMS_ASSEMBLIES)
+ $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(UNSAFE) $(WARNASERROR) $(CMS_CSFILES) $(CMS_ASSEMBLIES)
FSpot.Core.dll: $(CORE_CSFILES) FSpot.Utils.dll Cms.dll
@echo -e "\n*** Compiling $@"
- $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(CORE_CSFILES) $(CORE_ASSEMBLIES)
+ $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(WARNASERROR) $(CORE_CSFILES) $(CORE_ASSEMBLIES)
FSpot.Query.dll: $(QUERY_CSFILES) FSpot.Utils.dll FSpot.Core.dll
@echo -e "\n*** Compiling $@"
- $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(QUERY_CSFILES) $(QUERY_ASSEMBLIES)
+ $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(WARNASERROR) $(QUERY_CSFILES) $(QUERY_ASSEMBLIES)
FSpot.Utils.dll: $(UTILS_CSFILES)
@echo -e "\n*** Compiling $@"
@@ -466,18 +467,18 @@ FSpot.Utils.dll: $(UTILS_CSFILES)
FSpot.JobScheduler.dll: $(JOBSCHEDULER_CSFILES) FSpot.Utils.dll
@echo -e "\n*** Compiling $@"
- $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(JOBSCHEDULER_CSFILES) $(JOBSCHEDULER_ASSEMBLIES)
+ $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(WARNASERROR) $(JOBSCHEDULER_CSFILES) $(JOBSCHEDULER_ASSEMBLIES)
FSpot.Widgets.dll: $(WIDGETS_CSFILES) FSpot.Utils.dll FSpot.Core.dll
@echo -e "\n*** Compiling $@"
- $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(WIDGETS_CSFILES) $(WIDGETS_ASSEMBLIES)
+ $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(WARNASERROR) $(WIDGETS_CSFILES) $(WIDGETS_ASSEMBLIES)
PLATFORM_CSFILES = $(GNOME_PLATFORM_CSFILES)
PLATFORM_ASSEMBLIES = $(GNOME_PLATFORM_ASSEMBLIES)
FSpot.Platform.dll: $(PLATFORM_CSFILES) FSpot.Utils.dll
@echo -e "\n*** Compiling $@"
- $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(PLATFORM_CSFILES) $(PLATFORM_ASSEMBLIES)
+ $(CSC_LIB) -out:$@ $(EXTRAFLAGS) $(WARNASERROR) $(PLATFORM_CSFILES) $(PLATFORM_ASSEMBLIES)
f-spot.exe: $(F_SPOT_CSFILES) FSpot.Utils.dll FSpot.Core.dll FSpot.Query.dll FSpot.JobScheduler.dll FSpot.Widgets.dll Cms.dll FSpot.Platform.dll $(F_SPOT_RESOURCES)
@echo -e "\n*** Compiling $@"
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]