[evolution-mapi] Bug 585641 – evolution-mapi stores cleartext passwords in a world readable file



commit dba8b06449245775ff0508599abde89027d42b3e
Author: Johnny Jacob <jjohnny novell com>
Date:   Mon Jun 22 17:21:40 2009 +0530

    Bug 585641 â?? evolution-mapi stores cleartext passwords in a world readable file
    
    	* exchange-mapi-connection.c (exchange_mapi_create_profile): Do not save
    	the password in mapi-profiles.ldb.

 src/libexchangemapi/ChangeLog                  |    7 +++++++
 src/libexchangemapi/exchange-mapi-connection.c |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/src/libexchangemapi/ChangeLog b/src/libexchangemapi/ChangeLog
index bc1176b..afa11c2 100644
--- a/src/libexchangemapi/ChangeLog
+++ b/src/libexchangemapi/ChangeLog
@@ -1,3 +1,10 @@
+2009-06-22  Johnny Jacob  <jjohnny novell com>
+
+	** Fixes Bug 585641 â?? evolution-mapi stores cleartext passwords in a world readable file
+
+	* exchange-mapi-connection.c (exchange_mapi_create_profile): Do not save
+	the password in mapi-profiles.ldb.
+
 2009-06-09  Johnny Jacob  <jjohnny novell com>
 
 	* exchange-mapi-connection.c (mapi_profile_load): Added MAPI_DEBUG.
diff --git a/src/libexchangemapi/exchange-mapi-connection.c b/src/libexchangemapi/exchange-mapi-connection.c
index a7cf929..f75b878 100644
--- a/src/libexchangemapi/exchange-mapi-connection.c
+++ b/src/libexchangemapi/exchange-mapi-connection.c
@@ -2930,7 +2930,7 @@ exchange_mapi_create_profile (const char *username, const char *password, const
 	retval = DeleteProfile(profname); 
 	/* don't bother to check error - it would be valid if we got an error */
 
-	retval = CreateProfile(profname, username, password, 0); 
+	retval = CreateProfile(profname, username, password, OC_PROFILE_NOPASSWORD);
 	if (retval != MAPI_E_SUCCESS) {
 		manage_mapi_error ("CreateProfile", GetLastError(), error_msg);
 		goto cleanup; 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]