[gcompris] When shuffling the items for the left bar, the last item was skipped. As the



commit dd1080968158f6d1e661d5ef1951c10f59caa51e
Author: Wolfram Sang <wolfram iswi org>
Date:   Fri Jun 19 00:15:32 2009 +0200

    When shuffling the items for the left bar, the last item was skipped. As the
    upper limit for random-functions is exclusive, we have to pass the whole
    list_size, not list_size - 1. Also, simplify the code.

 src/boards/shapegame.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/boards/shapegame.c b/src/boards/shapegame.c
index d6e69f4..41d394b 100644
--- a/src/boards/shapegame.c
+++ b/src/boards/shapegame.c
@@ -1697,7 +1697,7 @@ parse_doc(xmlDocPtr doc)
     {
       Shape *shape;
 
-      i = list_length == 1 ? 0 : g_random_int_range(0, g_list_length(shape_list_init)-1);
+      i = g_random_int_range(0, list_length);
       shape = g_list_nth_data(shape_list_init, i);
       add_shape_to_canvas(shape);
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]