[jhbuild: 35/60] [gui] add a comment about fork_command envv parameter, with a bug number



commit 5e2465137a9b5b376fcebc5c202fbdf43ab9351b
Author: Frédéric Péters <fpeters 0d be>
Date:   Mon May 18 17:43:14 2009 +0200

    [gui] add a comment about fork_command envv parameter, with a bug number
---
 jhbuild/frontends/gtkui.py |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/jhbuild/frontends/gtkui.py b/jhbuild/frontends/gtkui.py
index 1360d97..ed8a8fe 100644
--- a/jhbuild/frontends/gtkui.py
+++ b/jhbuild/frontends/gtkui.py
@@ -439,6 +439,9 @@ class AppWindow(gtk.Window, buildscript.BuildScript):
                 env.update(extra_env)
 
             self.vte_fork_running = True
+            # environment must be passed as a sequence of strings (FOO=1, BAR=2)
+            # this is not Pythonic, GNOME bug 583078 has been filed to support
+            # passing of a dictionary.
             self.child_pid = self.terminal.fork_command(command=command[0], argv=command,
                     envv=['%s=%s' % x for x in env.items()], directory=cwd)
             while self.vte_fork_running:



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]