[epiphany] Correctly handle the 'cancel' case in the download decision dialog



commit 2aa3ce4a65e157968b159554ecb554a269a3915c
Author: Gustavo Noronha Silva <kov debian org>
Date:   Mon Jun 1 23:42:42 2009 -0300

    Correctly handle the 'cancel' case in the download decision dialog
    
    Bug #583855
    
    The code that handled responses for the download decision dialog was
    getting the downloader view from the embed too early. This change
    confines the request for the downloader view to the condition block
    that actually uses it.
---
 embed/webkit/webkit-embed.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/embed/webkit/webkit-embed.c b/embed/webkit/webkit-embed.c
index f98e603..7794ea8 100644
--- a/embed/webkit/webkit-embed.c
+++ b/embed/webkit/webkit-embed.c
@@ -537,7 +537,7 @@ confirm_action_response_cb (GtkWidget *dialog,
                             WebKitDownload *download)
 {
   WebKitWebView *web_view = g_object_get_data (G_OBJECT(dialog), "webkit-view");
-  DownloaderView *dview = EPHY_DOWNLOADER_VIEW (ephy_embed_shell_get_downloader_view (embed_shell));
+  DownloaderView *dview;
 
   gtk_widget_destroy (dialog);
 
@@ -562,6 +562,7 @@ confirm_action_response_cb (GtkWidget *dialog,
       if (!define_destination_uri (download, FALSE)) {
         goto cleanup;
       }
+      dview = EPHY_DOWNLOADER_VIEW (ephy_embed_shell_get_downloader_view (embed_shell));
       downloader_view_add_download (dview, download);
     }
     g_object_unref (download);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]