[rhythmbox] shell-player: remove idle handler used to emit notify::playing
- From: Jonathan Matthew <jmatthew src gnome org>
- To: svn-commits-list gnome org
- Subject: [rhythmbox] shell-player: remove idle handler used to emit notify::playing
- Date: Mon, 1 Jun 2009 04:19:05 -0400 (EDT)
commit 69c625560037fb53c186f526f769cbb2a089dabd
Author: Jonathan Matthew <jonathan d14n org>
Date: Mon Jun 1 18:17:27 2009 +1000
shell-player: remove idle handler used to emit notify::playing
This is no longer needed as the playing-stream handler already emits
notify::playing. The idle handler was a hack anyway, as there's no
guarantee the stream would really be playing by the time it was called.
---
shell/rb-shell-player.c | 23 -----------------------
1 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/shell/rb-shell-player.c b/shell/rb-shell-player.c
index 93cdd57..d039c12 100644
--- a/shell/rb-shell-player.c
+++ b/shell/rb-shell-player.c
@@ -279,7 +279,6 @@ struct RBShellPlayerPrivate
guint do_next_idle_id;
guint unblock_play_id;
- guint notify_playing_id;
};
#define RB_SHELL_PLAYER_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), RB_TYPE_SHELL_PLAYER, RBShellPlayerPrivate))
@@ -712,19 +711,6 @@ reemit_playing_signal (RBShellPlayer *player,
rb_player_playing (player->priv->mmplayer));
}
-static gboolean
-notify_playing_idle (RBShellPlayer *player)
-{
- GDK_THREADS_ENTER ();
- rb_debug ("emitting playing notification: %d", rb_player_playing (player->priv->mmplayer));
- g_object_notify (G_OBJECT (player), "playing");
- rb_shell_player_sync_buttons (player);
-
- player->priv->notify_playing_id = 0;
- GDK_THREADS_LEAVE ();
- return FALSE;
-}
-
static int
rb_shell_player_get_crossfade (RBShellPlayer *player, PlaybackStartType play_type)
{
@@ -768,10 +754,6 @@ rb_shell_player_open_playlist_url (RBShellPlayer *player,
g_error_free (error);
GDK_THREADS_LEAVE ();
}
- if (player->priv->notify_playing_id == 0) {
- player->priv->notify_playing_id = g_idle_add ((GSourceFunc) notify_playing_idle,
- player);
- }
}
static void
@@ -1241,11 +1223,6 @@ rb_shell_player_dispose (GObject *object)
player->priv->unblock_play_id = 0;
}
- if (player->priv->notify_playing_id != 0) {
- g_source_remove (player->priv->notify_playing_id);
- player->priv->notify_playing_id = 0;
- }
-
G_OBJECT_CLASS (rb_shell_player_parent_class)->dispose (object);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]