[vinagre/ssh: 4/4] Reorganized constructor of SSH tab



commit f8122343ef13a380fc3638094cc5e250df7b46e5
Author: Jonh Wendell <jwendell gnome org>
Date:   Thu Jul 30 16:46:04 2009 -0300

    Reorganized constructor of SSH tab

 plugins/ssh/vinagre-ssh-tab.c |   45 ++++++++++++++++------------------------
 1 files changed, 18 insertions(+), 27 deletions(-)
---
diff --git a/plugins/ssh/vinagre-ssh-tab.c b/plugins/ssh/vinagre-ssh-tab.c
index 3e312ad..5700989 100644
--- a/plugins/ssh/vinagre-ssh-tab.c
+++ b/plugins/ssh/vinagre-ssh-tab.c
@@ -38,9 +38,6 @@ struct _VinagreSshTabPrivate
 
 G_DEFINE_TYPE (VinagreSshTab, vinagre_ssh_tab, VINAGRE_TYPE_TAB)
 
-
-static void open_ssh (VinagreSshTab *ssh_tab);
-
 static gchar *
 ssh_tab_get_tooltip (VinagreTab *tab)
 {
@@ -62,34 +59,15 @@ ssh_tab_get_screenshot (VinagreTab *tab)
 static void
 vinagre_ssh_tab_constructed (GObject *object)
 {
-  open_ssh (VINAGRE_SSH_TAB (object));
-}
-
-static void 
-vinagre_ssh_tab_class_init (VinagreSshTabClass *klass)
-{
-  GObjectClass *object_class = G_OBJECT_CLASS (klass);
-  VinagreTabClass* tab_class = VINAGRE_TAB_CLASS (klass);
-
-  object_class->constructed = vinagre_ssh_tab_constructed;
-
-  tab_class->impl_get_tooltip = ssh_tab_get_tooltip;
-  tab_class->impl_get_screenshot = ssh_tab_get_screenshot;
-
-  g_type_class_add_private (object_class, sizeof (VinagreSshTabPrivate));
-}
-
-static void
-open_ssh (VinagreSshTab *ssh_tab)
-{
   gchar **arg;
+  VinagreSshTab *ssh_tab = VINAGRE_SSH_TAB (object);
 
   arg = g_new (gchar *, 5);
   arg[0] = g_strdup ("ssh");
   arg[1] = g_strdup (vinagre_connection_get_host (vinagre_tab_get_conn (VINAGRE_TAB (ssh_tab))));
-  arg[3] = g_strdup ("-p");
-  arg[4] = g_strdup_printf ("%d", vinagre_connection_get_port (vinagre_tab_get_conn (VINAGRE_TAB (ssh_tab))));
-  arg[5] = NULL;
+  arg[2] = g_strdup ("-p");
+  arg[3] = g_strdup_printf ("%d", vinagre_connection_get_port (vinagre_tab_get_conn (VINAGRE_TAB (ssh_tab))));
+  arg[4] = NULL;
 
   vte_terminal_fork_command (VTE_TERMINAL (ssh_tab->priv->vte),
 			     "ssh",
@@ -100,10 +78,23 @@ open_ssh (VinagreSshTab *ssh_tab)
 			     FALSE,
 			     FALSE);
   g_strfreev (arg);
-
   gtk_widget_show_all (GTK_WIDGET (ssh_tab));
 }
 
+static void 
+vinagre_ssh_tab_class_init (VinagreSshTabClass *klass)
+{
+  GObjectClass *object_class = G_OBJECT_CLASS (klass);
+  VinagreTabClass* tab_class = VINAGRE_TAB_CLASS (klass);
+
+  object_class->constructed = vinagre_ssh_tab_constructed;
+
+  tab_class->impl_get_tooltip = ssh_tab_get_tooltip;
+  tab_class->impl_get_screenshot = ssh_tab_get_screenshot;
+
+  g_type_class_add_private (object_class, sizeof (VinagreSshTabPrivate));
+}
+
 static void
 ssh_disconnected_cb (VteTerminal *ssh, VinagreSshTab *tab)
 {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]