[seed] [libseed] Add more attractive way to define GObject properties on newly created GTypes.

[Tim Horton <hortont src gnome org>]

commit 90ccc29b60c2ba4dd2d77c50dad497ed4f05acb3
Author: Tim Horton <hortont424 gmail com>
Date:   Thu Jul 30 21:30:14 2009 -0400

    [libseed] Add more attractive way to define GObject properties on newly created GTypes.
    
    This is incomplete as of yet (only supports bool and char properties, but it's mostly just copy-'n-paste from here on out).
    
    Also, add a test that shows how to use this (to add a single boolean property, the others follow in an obvious way, except add "maximum_value" and "minimum_value" properties for properties that use them.
    
    This also needs a *ton* more error checking.

 libseed/seed-gtype.c                           |  125 +++++++++++++++++++++++-
 tests/javascript/gtypes/gtype-property-nice.js |   32 ++++++
 2 files changed, 155 insertions(+), 2 deletions(-)
---
diff --git a/libseed/seed-gtype.c b/libseed/seed-gtype.c
index e69b3c4..bbcc703 100644
--- a/libseed/seed-gtype.c
+++ b/libseed/seed-gtype.c
@@ -421,6 +421,121 @@ seed_gtype_install_signals (JSContextRef ctx,
     }
 }
 
+static unsigned int
+seed_gtype_install_properties (JSContextRef ctx,
+			       JSObjectRef definition,
+			       GType type, GObjectClass *g_class)
+{
+  JSObjectRef properties, property_def;
+  JSValueRef jslength;
+  guint i, length;
+  GType property_type;
+  GParamFlags flags;
+  JSValueRef jsname, jsflags, jsproperty_type, jsdefault_value;
+  JSValueRef jsnick, jsblurb, jsmin_value, jsmax_value;
+  gchar *name , *nick, *blurb;
+  GParamSpec *pspec;
+  guint property_count = 0;
+
+  properties = (JSObjectRef) seed_object_get_property (ctx, definition,
+						       "properties");
+  if (JSValueIsNull (ctx, properties) || !JSValueIsObject (ctx, properties))
+    return 0;
+
+  jslength = seed_object_get_property (ctx, properties, "length");
+  if (JSValueIsNull (ctx, jslength))
+    return 0;
+
+  length = seed_value_to_uint (ctx, jslength, NULL);
+  for (i = 0; i < length; i++)
+    {
+      property_def = (JSObjectRef) JSObjectGetPropertyAtIndex (ctx,
+							       (JSObjectRef)
+							       properties, i,
+							       NULL);
+
+      if (JSValueIsNull (ctx, property_def)
+	  || !JSValueIsObject (ctx, property_def))
+	continue;
+
+      // TODO: Error checking
+      jsname = seed_object_get_property (ctx, property_def, "name");
+      name = seed_value_to_string (ctx, jsname, NULL);
+
+      // Check for "nick" property; set to name if nonexistent
+      jsnick = seed_object_get_property (ctx, property_def, "nick");
+      if (!JSValueIsString(ctx, jsnick))
+	nick = name;
+      else
+	nick = seed_value_to_string (ctx, jsnick, NULL);
+
+      // Check for "blurb" property; set to name if nonexistent
+      jsblurb = seed_object_get_property (ctx, property_def, "blurb");
+      if (!JSValueIsString(ctx, jsblurb))
+	blurb = name;
+      else
+	blurb = seed_value_to_string (ctx, jsblurb, NULL);
+
+      SEED_NOTE (GTYPE, "Installing property with name: %s on type: %s",
+		 name, g_type_name (type));
+      
+      jsflags =
+	seed_object_get_property (ctx, (JSObjectRef) property_def, "flags");
+      if (JSValueIsNull (ctx, jsflags) || !JSValueIsNumber (ctx, jsflags))
+	flags = G_PARAM_READABLE | G_PARAM_WRITABLE;
+      else
+	flags = seed_value_to_long (ctx, jsflags, NULL);
+
+      jsproperty_type = seed_object_get_property (ctx, property_def, "type");
+
+      // TODO: having no type should be an exception or something
+      if (JSValueIsNull (ctx, jsproperty_type) ||
+	  !JSValueIsNumber (ctx, jsproperty_type))
+	property_type = G_TYPE_NONE;
+      else
+	property_type = seed_value_to_long (ctx, jsproperty_type, NULL);
+
+      jsdefault_value = seed_object_get_property (ctx, property_def,
+						  "default_value");
+      jsmin_value = seed_object_get_property (ctx, property_def,
+					      "minimum_value");
+      jsmax_value = seed_object_get_property (ctx, property_def,
+					      "maximum_value");
+
+      // TODO: too many null exceptions throughout this
+      switch(property_type)
+	{
+	case G_TYPE_BOOLEAN:
+	  pspec = g_param_spec_boolean(name, nick, blurb,
+				       seed_value_to_boolean(ctx,
+							     jsdefault_value,
+							     NULL), flags);
+	  break;
+	case G_TYPE_CHAR:
+	  pspec = g_param_spec_char(name, nick, blurb,
+				    seed_value_to_char(ctx,
+						       jsmin_value,
+						       NULL),
+				    seed_value_to_char(ctx,
+						       jsmax_value,
+						       NULL),
+				    seed_value_to_char(ctx,
+						       jsdefault_value,
+						       NULL), flags);
+	  break;
+	default:
+	  g_print("arst unknown type\n"); // TODO: exception or something
+	  break;
+	}
+
+      g_object_class_install_property (g_class, ++property_count, pspec);
+
+      g_free (name); // TODO: more to free, after it works...
+    }
+
+  return property_count;
+}
+
 static void
 seed_gtype_class_init (gpointer g_class, gpointer class_data)
 {
@@ -431,6 +546,7 @@ seed_gtype_class_init (gpointer g_class, gpointer class_data)
   GType type;
   gchar *mes;
   JSValueRef exception = NULL;
+  int initial_prop_count = 1;
 
   priv = (SeedGClassPrivates *) class_data;
 
@@ -442,6 +558,10 @@ seed_gtype_class_init (gpointer g_class, gpointer class_data)
 
   type = (GType) JSObjectGetPrivate (priv->constructor);
   seed_gtype_install_signals (ctx, priv->definition, type);
+  initial_prop_count = seed_gtype_install_properties (ctx,
+						      priv->definition,
+						      type,
+						      (GObjectClass *) g_class);
 
   if (!priv->func)
     {
@@ -467,8 +587,9 @@ seed_gtype_class_init (gpointer g_class, gpointer class_data)
   seed_object_set_property (ctx, (JSObjectRef) jsargs[0],
 			    "type", seed_value_from_int (ctx, type, 0));
   seed_object_set_property (ctx, (JSObjectRef) jsargs[0],
-			    "property_count", seed_value_from_int (ctx, 1,
-								   0));
+			    "property_count",
+			    seed_value_from_int (ctx, initial_prop_count + 1,
+						 0));
 
   JSObjectCallAsFunction (ctx, priv->func, 0, 2, jsargs, &exception);
   if (exception)
diff --git a/tests/javascript/gtypes/gtype-property-nice.js b/tests/javascript/gtypes/gtype-property-nice.js
new file mode 100755
index 0000000..d8958a8
--- /dev/null
+++ b/tests/javascript/gtypes/gtype-property-nice.js
@@ -0,0 +1,32 @@
+#!/usr/bin/env seed
+// Returns: 0
+// STDIN:
+// STDOUT:1\n1\n0
+// STDERR:
+
+GObject = imports.gi.GObject;
+Gtk = imports.gi.Gtk;
+Gtk.init(Seed.argv);
+
+HelloWindowType = {
+    parent: Gtk.Window.type,
+    name: "HelloWindow",
+    properties: [{name: "randomproperty",
+		  type: GObject.TYPE_BOOLEAN,
+		  nick: "randomproperty",
+		  blurb: "longer blurb about property",
+		  default_value: true,
+		  flags: (GObject.ParamFlags.CONSTRUCT | GObject.ParamFlags.READABLE | GObject.ParamFlags.WRITABLE)}],
+    init: function(klass)
+    {
+
+    }};
+
+HelloWindow = new GType(HelloWindowType);
+w = new HelloWindow();
+
+print(w.randomproperty);
+w.randomproperty = 5;
+print(w.randomproperty);
+w.randomproperty = 0;
+print(w.randomproperty);