[evolution] BUG #480095 (BNC) - Alpha Search In Proxy Dialog Crashes Evolution.

commit 919a9bde9c9af0ef4a2119909c6de9e4042de3e0
Author: Bharath Acharya <abharath novell com>
Date:   Mon Jul 27 10:45:49 2009 +0530

    BUG #480095 (BNC) -  Alpha Search In Proxy Dialog Crashes Evolution.
    * proxy-login.c (proxy_login_tree_view_changed_cb): Use the unique
    stamp to catch only the valid iterators.
    Bug description:
    If you right mouse click on your Groupwise email account, you can select "Proxy
    Login" and a dialog appears with all of your previously used accounts in a
    list.  If you click focus into the list and then type in a keyboard letter it
    crashes.  This should position you at the first match of that letter, or at
    least not crash :)

 plugins/groupwise-features/proxy-login.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/plugins/groupwise-features/proxy-login.c b/plugins/groupwise-features/proxy-login.c
index 00d851f..b8fe495 100644
--- a/plugins/groupwise-features/proxy-login.c
+++ b/plugins/groupwise-features/proxy-login.c
@@ -400,7 +400,9 @@ proxy_login_tree_view_changed_cb(GtkDialog *dialog)
 	account_select = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->tree));
 	gtk_tree_selection_get_selected (account_select, &model, &iter);
-        gtk_tree_model_get (model, &iter, ACCOUNT_NAME, &account_mailid, -1);
+	if ((priv->store)->stamp != (&iter)->stamp)
+		return;
+	gtk_tree_model_get (model, &iter, ACCOUNT_NAME, &account_mailid, -1);
 	account_mailid = g_strrstr (account_mailid, "\n") + 1;
 	account_name_tbox = glade_xml_get_widget (priv->xml, "account_name");
 	gtk_entry_set_text((GtkEntry*) account_name_tbox,account_mailid);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]