[libgdamm] update_meta_store_table(): Comment out the use of gda_sql_identifier_quote() because we now have the



commit dba2e632313bf460d23ddb6f326d29dc98d68c93
Author: Murray Cumming <murrayc murrayc com>
Date:   Fri Jul 24 01:20:38 2009 +0200

    update_meta_store_table(): Comment out the use of gda_sql_identifier_quote() because we now have the
    	CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE connection option
    	instead.

 ChangeLog                 |    7 +++++++
 libgda/src/connection.ccg |   12 ++++++------
 2 files changed, 13 insertions(+), 6 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 83a7bfd..7dcf626 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-07-24  Murray Cumming  <murrayc murrayc com>
+
+	* libgda/src/connection.ccg: update_meta_store_table(): Comment out the 
+	use of gda_sql_identifier_quote() because we now have the 
+	CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE connection option 
+	instead.
+
 2009-07-23  Murray Cumming  <murrayc murrayc com>
 
 	* libgda/src/libgda_enums.defs: Regenerated with h2defs.py, against 
diff --git a/libgda/src/connection.ccg b/libgda/src/connection.ccg
index 22de523..2ab31ce 100644
--- a/libgda/src/connection.ccg
+++ b/libgda/src/connection.ccg
@@ -373,14 +373,14 @@ bool Connection::update_meta_store_table(const Glib::ustring& table_name, const
   // This ridiculous function, with the obscure parameters, is needed to make sure that 
   // the GdaMetaStore really gets the meta data for the table we specified, even if 
   // the table name contains upper-case characters or spaces. murrayc.
-  gchar* table_name_quoted = gda_sql_identifier_quote(table_name.c_str(), gobj(), NULL,
-    TRUE /* meta-store convention */, 
-    TRUE /* force_quotes - Yes, the really_do_what_i_say() function has a really_really_do_what_i_say parameter. */ );
-  std::cout << "Connection::update_meta_store_table(): table_name_quoted=" << table_name_quoted << std::endl;
+  //gchar* table_name_quoted = gda_sql_identifier_quote(table_name.c_str(), gobj(), NULL,
+  //  TRUE /* meta-store convention */, 
+  //  TRUE /* force_quotes - Yes, the really_do_what_i_say() function has a really_really_do_what_i_say parameter. */ );
+  //std::cout << "Connection::update_meta_store_table(): table_name_quoted=" << table_name_quoted << std::endl;
   
   GValue table_name_value = { 0 };
   g_value_init(&table_name_value, G_TYPE_STRING);
-  g_value_set_static_string(&table_name_value, table_name_quoted);
+  g_value_set_static_string(&table_name_value, table_name.c_str());
 
   GValue table_schema_value = { 0 };
   g_value_init(&table_schema_value, G_TYPE_STRING);
@@ -397,7 +397,7 @@ bool Connection::update_meta_store_table(const Glib::ustring& table_name, const
   g_value_unset(&table_name_value);
   g_value_unset(&table_schema_value);
   
-  g_free(table_name_quoted);
+  //g_free(table_name_quoted);
 
 #ifdef GLIBMM_EXCEPTIONS_ENABLED
   if(gerror)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]