GNOME.org
 

[gimp] Get rid of artificial compiler warnings

commit b2b2b41e62644882fda64fcd63d17d5a78d9a428
Author: Martin Nordholts <martinn src gnome org>
Date:   Mon Jul 20 11:53:02 2009 +0200

    Get rid of artificial compiler warnings
    
    Get rid of artificial compiler warnings generated with the #warning
    directive. They pollute the build output and don't work as incentives
    for fixing stuff.

 app/actions/palettes-commands.c          |    4 +---
 app/core/gimpcurve.c                     |    4 +---
 app/core/gimpdrawable-curves.c           |    4 +---
 app/core/gimpdrawable.c                  |   12 +++---------
 app/core/gimpimagemap.c                  |    6 ------
 app/core/gimplayer.c                     |    4 +---
 app/core/gimpparamspecs-duplicate.c      |    4 +---
 app/core/gimpparamspecs.c                |    4 +---
 app/dialogs/quit-dialog.c                |    4 +---
 app/gegl/gimpdesaturateconfig.c          |    4 +---
 app/widgets/gimpcolormapeditor.c         |    4 +---
 app/widgets/gimpdialogfactory.c          |    4 +---
 app/widgets/gimpselectioneditor.c        |    4 +---
 app/widgets/gimptoolbox.c                |    4 +---
 app/widgets/gimpuimanager.c              |    4 +---
 libgimpwidgets/gimpoldwidgets.c          |    1 +
 plug-ins/common/gradient-map.c           |    4 +---
 plug-ins/file-xjt/xjt.c                  |    4 +---
 plug-ins/flame/flame.c                   |    4 +---
 plug-ins/gradient-flare/gradient-flare.c |    4 +---
 20 files changed, 21 insertions(+), 66 deletions(-)
---
diff --git a/app/actions/palettes-commands.c b/app/actions/palettes-commands.c
index 7c4a0fb..6acd9cc 100644
--- a/app/actions/palettes-commands.c
+++ b/app/actions/palettes-commands.c
@@ -90,9 +90,7 @@ palettes_merge_callback (GtkWidget   *widget,
                          const gchar *palette_name,
                          gpointer     data)
 {
-#ifdef __GNUC__
-#warning FIXME: reimplement palettes_merge_callback()
-#endif
+  /* FIXME: reimplement palettes_merge_callback() */
 #if 0
   GimpContainerEditor *editor;
   GimpPalette         *palette;
diff --git a/app/core/gimpcurve.c b/app/core/gimpcurve.c
index 3ae937d..2528dbd 100644
--- a/app/core/gimpcurve.c
+++ b/app/core/gimpcurve.c
@@ -868,9 +868,7 @@ gimp_curve_get_uchar (GimpCurve *curve,
   gint i;
 
   g_return_if_fail (GIMP_IS_CURVE (curve));
-#ifdef __GNUC__
-#warning: FIXME: support n_samples != curve->n_samples
-#endif
+  /* FIXME: support n_samples != curve->n_samples */
   g_return_if_fail (n_samples == curve->n_samples);
   g_return_if_fail (samples != NULL);
 
diff --git a/app/core/gimpdrawable-curves.c b/app/core/gimpdrawable-curves.c
index b92eccc..d4e900d 100644
--- a/app/core/gimpdrawable-curves.c
+++ b/app/core/gimpdrawable-curves.c
@@ -78,9 +78,7 @@ gimp_drawable_curves_spline (GimpDrawable *drawable,
 
   gimp_data_freeze (GIMP_DATA (curve));
 
-#ifdef __GNUC__
-#warning FIXME: create a curves object with the right number of points
-#endif
+  /* FIXME: create a curves object with the right number of points */
   /*  unset the last point  */
   gimp_curve_set_point (curve, curve->n_points - 1, -1, -1);
 
diff --git a/app/core/gimpdrawable.c b/app/core/gimpdrawable.c
index 3e9f6a5..7705cf5 100644
--- a/app/core/gimpdrawable.c
+++ b/app/core/gimpdrawable.c
@@ -370,9 +370,7 @@ gimp_drawable_visibility_changed (GimpItem *item)
                                 output, "input");
         }
 
-#ifdef __GNUC__
-#warning FIXME: chain up again when above floating sel special case is gone
-#endif
+      /* FIXME: chain up again when above floating sel special case is gone */
       return;
     }
 
@@ -1859,9 +1857,7 @@ gimp_drawable_attach_floating_sel (GimpDrawable *drawable,
 
   gimp_drawable_sync_source_node (drawable, FALSE);
 
-#ifdef __GNUC__
-#warning FIXME: remove this hack when the floating sel is no layer any longer
-#endif
+  /* FIXME: remove this hack when the floating sel is no layer any longer */
   g_signal_emit_by_name (floating_sel, "visibility-changed");
 }
 
@@ -1880,9 +1876,7 @@ gimp_drawable_detach_floating_sel (GimpDrawable *drawable,
 
   gimp_drawable_sync_source_node (drawable, TRUE);
 
-#ifdef __GNUC__
-#warning FIXME: remove this hack when the floating sel is no layer any longer
-#endif
+  /* FIXME: remove this hack when the floating sel is no layer any longer */
   g_signal_emit_by_name (floating_sel, "visibility-changed");
 
   /*  Invalidate the preview of the obscured drawable.  We do this here
diff --git a/app/core/gimpimagemap.c b/app/core/gimpimagemap.c
index 94a5da8..cc6a58c 100644
--- a/app/core/gimpimagemap.c
+++ b/app/core/gimpimagemap.c
@@ -37,12 +37,6 @@
 #include "gimpviewable.h"
 
 
-#ifdef __GNUC__
-#warning FIXME: gegl_node_get_pad() or something similar needs to be public
-#endif
-gpointer   gegl_node_get_pad (GeglNode    *self,
-                              const gchar *pad_name);
-
 enum
 {
   FLUSH,
diff --git a/app/core/gimplayer.c b/app/core/gimplayer.c
index e5b32a5..6c4fe0d 100644
--- a/app/core/gimplayer.c
+++ b/app/core/gimplayer.c
@@ -823,9 +823,7 @@ gimp_layer_transform (GimpItem               *item,
 {
   GimpLayer *layer = GIMP_LAYER (item);
 
-#ifdef __GNUC__
-#warning FIXME: make interpolated transformations work on layers without alpha
-#endif
+  /* FIXME: make interpolated transformations work on layers without alpha */
   if (interpolation_type != GIMP_INTERPOLATION_NONE &&
       ! gimp_drawable_has_alpha (GIMP_DRAWABLE (item)))
     gimp_layer_add_alpha (layer);
diff --git a/app/core/gimpparamspecs-duplicate.c b/app/core/gimpparamspecs-duplicate.c
index 1e462fa..21e2325 100644
--- a/app/core/gimpparamspecs-duplicate.c
+++ b/app/core/gimpparamspecs-duplicate.c
@@ -32,9 +32,7 @@
 #include "gimpparamspecs-duplicate.h"
 
 
-#ifdef __GNUC__
-#warning FIXME: this code is not yet general as it should be (gegl tool only atm)
-#endif
+/* FIXME: this code is not yet general as it should be (gegl tool only atm) */
 
 GParamSpec *
 gimp_param_spec_duplicate (GParamSpec *pspec)
diff --git a/app/core/gimpparamspecs.c b/app/core/gimpparamspecs.c
index 67069f4..1e83433 100644
--- a/app/core/gimpparamspecs.c
+++ b/app/core/gimpparamspecs.c
@@ -917,9 +917,7 @@ gimp_value_set_item (GValue   *value,
 {
   g_return_if_fail (item == NULL || GIMP_IS_ITEM (item));
 
-#ifdef __GNUC__
-#warning FIXME remove hack as soon as bug #375864 is fixed
-#endif
+  /* FIXME remove hack as soon as bug #375864 is fixed */
 
   if (GIMP_VALUE_HOLDS_ITEM_ID (value))
     {
diff --git a/app/dialogs/quit-dialog.c b/app/dialogs/quit-dialog.c
index 846e620..454f3d3 100644
--- a/app/dialogs/quit-dialog.c
+++ b/app/dialogs/quit-dialog.c
@@ -91,9 +91,7 @@ quit_close_all_dialog_new (Gimp     *gimp,
 
   g_return_val_if_fail (GIMP_IS_GIMP (gimp), NULL);
 
-#ifdef __GNUC__
-#warning FIXME: need container of dirty images
-#endif
+  /* FIXME: need container of dirty images */
 
   images  = gimp_displays_get_dirty_images (gimp);
   context = gimp_context_new (gimp, "close-all-dialog",
diff --git a/app/gegl/gimpdesaturateconfig.c b/app/gegl/gimpdesaturateconfig.c
index f188974..3f9dc85 100644
--- a/app/gegl/gimpdesaturateconfig.c
+++ b/app/gegl/gimpdesaturateconfig.c
@@ -62,9 +62,7 @@ gimp_desaturate_config_class_init (GimpDesaturateConfigClass *klass)
   object_class->set_property       = gimp_desaturate_config_set_property;
   object_class->get_property       = gimp_desaturate_config_get_property;
 
-#ifdef __GNUC__
-#warning FIXME: change string when a desaturate icon gets added
-#endif
+  /*FIXME: change string when a desaturate icon gets added */
   viewable_class->default_stock_id = "gimp-convert-grayscale";
 
   GIMP_CONFIG_INSTALL_PROP_ENUM (object_class, PROP_MODE,
diff --git a/app/widgets/gimpcolormapeditor.c b/app/widgets/gimpcolormapeditor.c
index 3252c30..17aec5e 100644
--- a/app/widgets/gimpcolormapeditor.c
+++ b/app/widgets/gimpcolormapeditor.c
@@ -19,9 +19,7 @@
 
 #include <string.h>
 
-#ifdef __GNUC__
-#warning FIXME: #undef GTK_DISABLE_DEPRECATED
-#endif
+/* FIXME: #undef GTK_DISABLE_DEPRECATED */
 #undef GTK_DISABLE_DEPRECATED
 
 #include <gegl.h>
diff --git a/app/widgets/gimpdialogfactory.c b/app/widgets/gimpdialogfactory.c
index df9cd8d..ff1c157 100644
--- a/app/widgets/gimpdialogfactory.c
+++ b/app/widgets/gimpdialogfactory.c
@@ -1461,9 +1461,7 @@ gimp_dialog_factories_clear_foreach (gconstpointer      key,
       if (info->widget)
         continue;
 
-#ifdef __GNUC__
-#warning FIXME: implement session info deletion
-#endif
+      /* FIXME: implement session info deletion */
     }
 }
 
diff --git a/app/widgets/gimpselectioneditor.c b/app/widgets/gimpselectioneditor.c
index a344f87..8910aa9 100644
--- a/app/widgets/gimpselectioneditor.c
+++ b/app/widgets/gimpselectioneditor.c
@@ -36,9 +36,7 @@
 #include "core/gimpselection.h"
 #include "core/gimptoolinfo.h"
 
-#ifdef __GNUC__
-#warning FIXME: #include "tools/tools-types.h"
-#endif
+/* FIXME: #include "tools/tools-types.h" */
 #include "tools/tools-types.h"
 #include "tools/gimpregionselectoptions.h"
 
diff --git a/app/widgets/gimptoolbox.c b/app/widgets/gimptoolbox.c
index 0ef36fc..c242cd7 100644
--- a/app/widgets/gimptoolbox.c
+++ b/app/widgets/gimptoolbox.c
@@ -827,9 +827,7 @@ toolbox_area_notify (GimpGuiConfig *config,
 
       gtk_widget_show (parent);
 
-#ifdef __GNUC__
-#warning FIXME: fix GtkWrapBox child requisition/allocation instead of hacking badly (bug #162500).
-#endif
+      /* FIXME: fix GtkWrapBox child requisition/allocation instead of hacking badly (bug #162500). */
       gtk_widget_size_request (area, &req);
       gtk_widget_set_size_request (parent, req.width, req.height);
     }
diff --git a/app/widgets/gimpuimanager.c b/app/widgets/gimpuimanager.c
index 983ee4b..ed71ba7 100644
--- a/app/widgets/gimpuimanager.c
+++ b/app/widgets/gimpuimanager.c
@@ -1053,9 +1053,7 @@ gimp_ui_manager_item_key_press (GtkWidget     *widget,
 /* Stuff below taken from gtktooltip.c
  */
 
-#ifdef __GNUC__
-#warning FIXME: remove this crack as soon as a GTK+ widget_under_pointer() is available
-#endif
+/* FIXME: remove this crack as soon as a GTK+ widget_under_pointer() is available */
 
 struct ChildLocation
 {
diff --git a/libgimpwidgets/gimpoldwidgets.c b/libgimpwidgets/gimpoldwidgets.c
index f8172b0..7cc00ce 100644
--- a/libgimpwidgets/gimpoldwidgets.c
+++ b/libgimpwidgets/gimpoldwidgets.c
@@ -23,6 +23,7 @@
 
 #include <string.h>
 
+/* FIXME: #undef GTK_DISABLE_DEPRECATED */
 #undef GTK_DISABLE_DEPRECATED
 #include <gtk/gtk.h>
 
diff --git a/plug-ins/common/gradient-map.c b/plug-ins/common/gradient-map.c
index f4199d2..84685c9 100644
--- a/plug-ins/common/gradient-map.c
+++ b/plug-ins/common/gradient-map.c
@@ -264,9 +264,7 @@ get_samples_gradient (GimpDrawable *drawable)
 
   gradient_name = gimp_context_get_gradient ();
 
-#ifdef __GNUC__
-#warning FIXME: "reverse" hardcoded to FALSE.
-#endif
+  /* FIXME: "reverse" hardcoded to FALSE. */
   gimp_gradient_get_uniform_samples (gradient_name, NSAMPLES, FALSE,
                                      &n_f_samples, &f_samples);
 
diff --git a/plug-ins/file-xjt/xjt.c b/plug-ins/file-xjt/xjt.c
index 22d3293..f07be5d 100644
--- a/plug-ins/file-xjt/xjt.c
+++ b/plug-ins/file-xjt/xjt.c
@@ -66,9 +66,7 @@
 
 #include <glib/gstdio.h>
 
-#ifdef __GNUC__
-#warning GIMP_DISABLE_DEPRECATED
-#endif
+/* FIXME: #undef GTK_DISABLE_DEPRECATED */
 #undef GIMP_DISABLE_DEPRECATED
 
 #include <libgimp/gimp.h>
diff --git a/plug-ins/flame/flame.c b/plug-ins/flame/flame.c
index f83eac2..16cbc22 100644
--- a/plug-ins/flame/flame.c
+++ b/plug-ins/flame/flame.c
@@ -271,9 +271,7 @@ drawable_to_cmap (control_point *cp)
       gint     num;
       gdouble *g;
 
-#ifdef __GNUC__
-#warning FIXME: "reverse" hardcoded to FALSE.
-#endif
+      /* FIXME: "reverse" hardcoded to FALSE. */
       gimp_gradient_get_uniform_samples (name, 256, FALSE,
                                          &num, &g);
 
diff --git a/plug-ins/gradient-flare/gradient-flare.c b/plug-ins/gradient-flare/gradient-flare.c
index 5273d8f..92ed3e4 100644
--- a/plug-ins/gradient-flare/gradient-flare.c
+++ b/plug-ins/gradient-flare/gradient-flare.c
@@ -4878,9 +4878,7 @@ gradient_get_values_external (const gchar *gradient_name,
   ci = gradient_cache_lookup (gradient_name, &found);
   if (!found)
     {
-#ifdef __GNUC__
-#warning FIXME: "reverse" hardcoded to FALSE.
-#endif
+      /* FIXME: "reverse" hardcoded to FALSE. */
       gradient_get_values_real_external (gradient_name, ci->values,
                                          GRADIENT_RESOLUTION, FALSE);
     }
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]