[glom/glom-1-10] Really save field changes again.



commit 57596210bf13ac69e02e0b5891344f12c82d7a0b
Author: Murray Cumming <murrayc murrayc com>
Date:   Fri Jul 10 17:06:24 2009 +0200

    Really save field changes again.
    
    	* glom/libglom/document/document_glom.cc: set_table_fields():
    	Avoid the broken attempt at optimization, so that field changes are always
    	saved, for instance when changing them via the Field Definition dialog.
    	Ubuntu Launchpad bug
    	https://bugs.launchpad.net/ubuntu/+source/glom/+bug/394507
    	(elmergato)

 ChangeLog                              |   11 +++++++++++
 glom/libglom/document/document_glom.cc |    2 +-
 2 files changed, 12 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 5e2eb1e..8d1b142 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2009-07-10  Murray Cumming  <murrayc murrayc com>
+
+	Really save field changes again.
+	
+	* glom/libglom/document/document_glom.cc: set_table_fields():
+	Avoid the broken attempt at optimization, so that field changes are always 
+	saved, for instance when changing them via the Field Definition dialog.
+	Ubuntu Launchpad bug 
+	https://bugs.launchpad.net/ubuntu/+source/glom/+bug/394507
+	(elmergato)
+
 2009-06-29  Murray Cumming  <murrayc murrayc com>
 
 	Export: Offer File overwrite confirmation.
diff --git a/glom/libglom/document/document_glom.cc b/glom/libglom/document/document_glom.cc
index b07a117..8a5710a 100644
--- a/glom/libglom/document/document_glom.cc
+++ b/glom/libglom/document/document_glom.cc
@@ -840,7 +840,7 @@ void Document_Glom::set_table_fields(const Glib::ustring& table_name, const type
     }
 
     DocumentTableInfo& info = get_table_info_with_add(table_name);
-    const bool will_change = (info.m_fields != vecFields); //TODO: Does this do a deep comparison?
+    const bool will_change = true; //This won't work because we didn't clone the fields before changing them: (info.m_fields != vecFields); //TODO: Does this do a deep comparison?
     info.m_fields = vecFields;
 
     set_modified(will_change);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]