[network-manager-netbook] Fix a memory corruption.



commit eb21a6209b4894f52cbc3e153f1221078982b878
Author: Tambet Ingo <tambet gmail com>
Date:   Wed Jul 8 12:03:58 2009 +0300

    Fix a memory corruption.
    
    This happened when a new 3G or wifi connection was added, followed by disable/
    enable 3G/wifi switch toggle. Possibly fixes bnc #518283.

 src/nmn-new-connection.c |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)
---
diff --git a/src/nmn-new-connection.c b/src/nmn-new-connection.c
index 6402be5..46425d0 100644
--- a/src/nmn-new-connection.c
+++ b/src/nmn-new-connection.c
@@ -98,12 +98,7 @@ save_connection (NmnNMData *data, NMConnection *connection)
 
     exported = nma_gconf_settings_add_connection (settings, connection);
 
-    if (exported) {
-        g_object_unref (exported);
-        return TRUE;
-    }
-
-    return FALSE;
+    return exported != NULL;
 }
 
 static void
@@ -505,13 +500,9 @@ mobile_save_clicked (GtkButton *button, gpointer user_data)
         nmn_mobile_provider_unref (provider);
 
         if (connection) {
-            NMExportedConnection *exported;
-
-            exported = NM_EXPORTED_CONNECTION (nma_gconf_settings_add_connection (NMA_GCONF_SETTINGS (nmn_nm_data_get_user_settings (priv->nm_data)), connection));
-
+            nma_gconf_settings_add_connection (NMA_GCONF_SETTINGS (nmn_nm_data_get_user_settings (priv->nm_data)),
+                                               connection);
             g_object_unref (connection);
-            if (exported)
-                g_object_unref (exported);
         }
 
         gtk_widget_hide (GTK_WIDGET (self));



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]