empathy r2343 - trunk/libempathy-gtk



Author: xclaesse
Date: Fri Jan 30 17:35:00 2009
New Revision: 2343
URL: http://svn.gnome.org/viewvc/empathy?rev=2343&view=rev

Log:
Reorganize the constructor to avoid some casts and to avoid complex inline initializations.

Modified:
   trunk/libempathy-gtk/empathy-contact-selector.c

Modified: trunk/libempathy-gtk/empathy-contact-selector.c
==============================================================================
--- trunk/libempathy-gtk/empathy-contact-selector.c	(original)
+++ trunk/libempathy-gtk/empathy-contact-selector.c	Fri Jan 30 17:35:00 2009
@@ -220,13 +220,18 @@
                               guint n_construct_params,
                               GObjectConstructParam *construct_params)
 {
-  GObject *object =
-      G_OBJECT_CLASS (empathy_contact_selector_parent_class)->constructor (
-          type, n_construct_params, construct_params);
-  EmpathyContactSelector *contact_selector = EMPATHY_CONTACT_SELECTOR (object);
-  EmpathyContactSelectorPriv *priv = GET_PRIV (contact_selector);
+  GObject *object;
+  EmpathyContactSelector *contact_selector;
+  EmpathyContactSelectorPriv *priv;
+  GtkCellLayout *cell_layout;
   GtkCellRenderer *renderer;
 
+  object = G_OBJECT_CLASS (empathy_contact_selector_parent_class)->constructor 
+    (type, n_construct_params, construct_params);
+  priv = GET_PRIV (object);
+  contact_selector = EMPATHY_CONTACT_SELECTOR (object);
+  cell_layout = GTK_CELL_LAYOUT (object);
+
   g_object_set (priv->store, "is-compact", TRUE, "show-avatars", FALSE,
       "show-offline", FALSE, "show-groups", FALSE,
       "sort-criterium", EMPATHY_CONTACT_LIST_STORE_SORT_NAME, NULL);
@@ -244,21 +249,18 @@
   gtk_widget_set_sensitive (GTK_WIDGET (contact_selector), FALSE);
 
   renderer = gtk_cell_renderer_pixbuf_new ();
-  gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (contact_selector),
-      renderer, FALSE);
-  gtk_cell_layout_set_attributes (GTK_CELL_LAYOUT (contact_selector), renderer,
+  gtk_cell_layout_pack_start (cell_layout, renderer, FALSE);
+  gtk_cell_layout_set_attributes (cell_layout, renderer,
       "icon-name", EMPATHY_CONTACT_LIST_STORE_COL_ICON_STATUS, NULL);
 
   renderer = gtk_cell_renderer_text_new ();
-  gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (contact_selector),
-      renderer, TRUE);
-  gtk_cell_layout_set_attributes (GTK_CELL_LAYOUT (contact_selector), renderer,
+  gtk_cell_layout_pack_start (cell_layout, renderer, TRUE);
+  gtk_cell_layout_set_attributes (cell_layout, renderer,
       "text", EMPATHY_CONTACT_LIST_STORE_COL_NAME, NULL);
 
   contact_selector_manage_blank_contact (contact_selector);
   contact_selector_manage_sensitivity (contact_selector);
 
-  object = G_OBJECT (contact_selector);
   return object;
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]