empathy r2300 - trunk/src

[xclaesse svn gnome org]

Author: xclaesse
Date: Fri Jan 30 17:08:23 2009
New Revision: 2300
URL: http://svn.gnome.org/viewvc/empathy?rev=2300&view=rev

Log:
Update the pixbuf when we receive an event update.

Modified:
   trunk/src/empathy-status-icon.c

Modified: trunk/src/empathy-status-icon.c
==============================================================================
--- trunk/src/empathy-status-icon.c	(original)
+++ trunk/src/empathy-status-icon.c	Fri Jan 30 17:08:23 2009
@@ -109,43 +109,52 @@
 	}
 }
 
+static GdkPixbuf *
+get_pixbuf_for_event (EmpathyEvent *event)
+{
+	GdkPixbuf *pixbuf = NULL;
+
+	if (event->contact != NULL) {
+		pixbuf = empathy_pixbuf_avatar_from_contact_scaled (event->contact,
+								    48, 48);
+	}
+
+	if (!pixbuf) {
+		pixbuf = empathy_pixbuf_from_icon_name_sized
+					(event->icon_name, 48);
+	}
+
+	return pixbuf;
+}
+
 static void
 status_icon_update_notification (EmpathyStatusIcon *icon)
 {
 	EmpathyStatusIconPriv *priv = GET_PRIV (icon);
+	GdkPixbuf *pixbuf = NULL;
 
 	if (priv->event) {
+		pixbuf = get_pixbuf_for_event (priv->event);
+
 		if (priv->notification) {
 			notify_notification_update (priv->notification,
 						    priv->event->header, priv->event->message,
 						    NULL);
 		} else {
-			GdkPixbuf *pixbuf = NULL;
-
-			if (priv->event->contact != NULL) {
-				pixbuf = empathy_pixbuf_avatar_from_contact_scaled (priv->event->contact,
-										    48, 48);
-			}
-
-			if (!pixbuf) {
-				pixbuf = empathy_pixbuf_from_icon_name_sized
-						(priv->event->icon_name, 48);
-			}
-
 			priv->notification = notify_notification_new_with_status_icon
 				(priv->event->header, priv->event->message, NULL, priv->icon);
 			notify_notification_set_timeout (priv->notification,
 							 NOTIFY_EXPIRES_DEFAULT);
-			notify_notification_set_icon_from_pixbuf (priv->notification,
-								  pixbuf);
 
 			g_signal_connect (priv->notification, "closed",
 					  G_CALLBACK (status_icon_notification_closed_cb), icon);
 
-			g_object_unref (pixbuf);
  		}
-
+		notify_notification_set_icon_from_pixbuf (priv->notification,
+							  pixbuf);
 		notify_notification_show (priv->notification, NULL);
+
+		g_object_unref (pixbuf);
 	} else {
 		if (priv->notification) {
 			notify_notification_close (priv->notification, NULL);