gnumeric r17087 - trunk/plugins/lotus-123

[mortenw svn gnome org]

Author: mortenw
Date: Fri Jan 23 21:25:58 2009
New Revision: 17087
URL: http://svn.gnome.org/viewvc/gnumeric?rev=17087&view=rev

Log:
Plug leaks.



Modified:
   trunk/plugins/lotus-123/ChangeLog
   trunk/plugins/lotus-123/lotus-formula.c

Modified: trunk/plugins/lotus-123/lotus-formula.c
==============================================================================
--- trunk/plugins/lotus-123/lotus-formula.c	(original)
+++ trunk/plugins/lotus-123/lotus-formula.c	Fri Jan 23 21:25:58 2009
@@ -485,6 +485,7 @@
 	guint     i;
 	GnmCellRef   a, b;
 	gboolean done = FALSE;
+	GnmExprTop const *res;
 
 	for (i = 0; (i < len) && !done;) {
 		switch (data[i]) {
@@ -563,10 +564,15 @@
 		}
 	}
 
-	if (gnm_expr_list_length (stack) != 1)
+	res = stack ? gnm_expr_top_new (parse_list_pop (&stack, orig)) : NULL;
+	if (stack) {
 		g_warning ("%s: args remain on stack",
 			   cell_coord_name (orig->eval.col, orig->eval.row));
-	return gnm_expr_top_new (parse_list_pop (&stack, orig));
+		while (stack)
+			gnm_expr_free (parse_list_pop (&stack, orig));
+	}
+
+	return res;
 }
 
 static void