ooo-build r15128 - in branches/ooo-build-3-0-1: . patches/dev300

[kyoshida svn gnome org]

Author: kyoshida
Date: Thu Jan 22 05:18:33 2009
New Revision: 15128
URL: http://svn.gnome.org/viewvc/ooo-build?rev=15128&view=rev

Log:
2009-01-22  Kohei Yoshida  <kyoshida novell com>

	* patches/dev300/calc-external-defined-names-empty-cells.diff:
	* patches/dev300/apply: treat non-cached cells as empty cells if the 
	enclosing table itself is cached.  This prevents #REF! error when the 
	referenced external cell is not in cache.  This patch is in the
	CalcExperimental section disabled by default.


Added:
   branches/ooo-build-3-0-1/patches/dev300/calc-external-defined-names-empty-cells.diff
Modified:
   branches/ooo-build-3-0-1/ChangeLog
   branches/ooo-build-3-0-1/patches/dev300/apply

Modified: branches/ooo-build-3-0-1/patches/dev300/apply
==============================================================================
--- branches/ooo-build-3-0-1/patches/dev300/apply	(original)
+++ branches/ooo-build-3-0-1/patches/dev300/apply	Thu Jan 22 05:18:33 2009
@@ -1841,6 +1841,7 @@
 calc-external-defined-names-offapi.diff, i#3740, i#4385, n#355685, kohei
 calc-external-defined-names-svtools.diff, i#3740, i#4385, n#355685, kohei
 calc-external-defined-names-officecfg.diff, i#3740, i#4385, n#355685, kohei
+calc-external-defined-names-empty-cells.diff, kohei
 
 # support custom names in data pilot tables.
 calc-dp-custom-names-sc.diff,     n#338014, i#22029, kohei

Added: branches/ooo-build-3-0-1/patches/dev300/calc-external-defined-names-empty-cells.diff
==============================================================================
--- (empty file)
+++ branches/ooo-build-3-0-1/patches/dev300/calc-external-defined-names-empty-cells.diff	Thu Jan 22 05:18:33 2009
@@ -0,0 +1,24 @@
+diff --git sc/source/ui/docshell/externalrefmgr.cxx sc/source/ui/docshell/externalrefmgr.cxx
+index ae5015d..d3f770b 100644
+--- sc/source/ui/docshell/externalrefmgr.cxx
++++ sc/source/ui/docshell/externalrefmgr.cxx
+@@ -161,7 +161,8 @@ ScExternalRefCache::TokenRef ScExternalRefCache::Table::getCell(SCCOL nCol, SCRO
+     if (itrTable == maRows.end())
+     {
+         // this table doesn't have the specified row.
+-        return TokenRef();
++        TokenRef p(new ScEmptyCellToken(false, false));
++        return p;
+     }
+ 
+     const RowDataType& rRowData = itrTable->second;
+@@ -169,7 +170,8 @@ ScExternalRefCache::TokenRef ScExternalRefCache::Table::getCell(SCCOL nCol, SCRO
+     if (itrRow == rRowData.end())
+     {
+         // this row doesn't have the specified column.
+-        return TokenRef();
++        TokenRef p(new ScEmptyCellToken(false, false));
++        return p;
+     }
+ 
+     const Cell& rCell = itrRow->second;