vala r2314 - in trunk: . vala



Author: juergbi
Date: Fri Jan  9 22:53:11 2009
New Revision: 2314
URL: http://svn.gnome.org/viewvc/vala?rev=2314&view=rev

Log:
2009-01-09  JÃrg Billeter  <j bitron ch>

	* vala/valasemanticanalyzer.vala:

	Fix memory leak when retrieving values from property getters
	returning owned values, fixes bug 564081


Modified:
   trunk/ChangeLog
   trunk/vala/valasemanticanalyzer.vala

Modified: trunk/vala/valasemanticanalyzer.vala
==============================================================================
--- trunk/vala/valasemanticanalyzer.vala	(original)
+++ trunk/vala/valasemanticanalyzer.vala	Fri Jan  9 22:53:11 2009
@@ -1,6 +1,7 @@
 /* valasemanticanalyzer.vala
  *
- * Copyright (C) 2006-2009  JÃrg Billeter, Raffaele Sandrini
+ * Copyright (C) 2006-2009  JÃrg Billeter
+ * Copyright (C) 2006-2008  Raffaele Sandrini
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -163,7 +164,10 @@
 			var prop = (Property) sym;
 			if (prop.property_type != null) {
 				var type = prop.property_type.copy ();
-				type.value_owned = false;
+				if (lvalue) {
+					// setters never take ownership
+					type.value_owned = false;
+				}
 				return type;
 			}
 		} else if (sym is FormalParameter) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]