GNOME.org
 

gnome-packagekit r467 - in trunk: . data src

Author: rhughes
Date: Thu Jan  8 16:54:48 2009
New Revision: 467
URL: http://svn.gnome.org/viewvc/gnome-packagekit?rev=467&view=rev

Log:
from git

Modified:
   trunk/NEWS
   trunk/configure.ac
   trunk/data/gpk-error.glade
   trunk/src/gpk-cell-renderer-uri.c
   trunk/src/gpk-enum.c
   trunk/src/gpk-error.c
   trunk/src/gpk-self-test.c
   trunk/src/gpk-update-viewer.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Thu Jan  8 16:54:48 2009
@@ -1,3 +1,53 @@
+Version 0.4.1
+~~~~~~~~~~~~~
+Released: 2000-01-08
+
+* Translations
+ - Added Kannada translation (Andre Klapper)
+ - Added Spanish language help screenshots (Jorge Gonzalez)
+ - Updated German translation (Andre Klapper)
+ - Updated Spanish translation (Daniel Mustieles)
+ - Updated Swedish translation (Daniel Nylander)
+ - Updated Greek help translation (Evgenia Petoumenou)
+ - Updated Greek translation (Evgenia Petoumenou)
+ - Updated Hungarian translation (Gabor Kelemen)
+ - Updated Spanish translation (Jorge Gonzalez, Daniel Mustieles)
+ - Updated Hebrew translation (Mark Krapivner)
+ - Updated Brazilian Portuguese translation (Michel Recondo)
+
+* New Features:
+ - Add an option to the prefs dialog to prevent checking for updates when
+   using mobile broadband connections (Richard Hughes)
+ - Allow the admin to restrict getting updates when on WiFi connections (Richard Hughes)
+ - Set the default search mode to details (not name) and preserve the search
+   type in GConf if changed in the UI (Richard Hughes)
+ - Add a simple markdown parser (Richard Hughes)
+ - Add dbus_default_interaction and dbus_enforced_interaction GConf keys and
+   some documentation (Richard Hughes)
+ - Send different errors when we fail a method on the session DBus interface (Richard Hughes)
+ - Support setting timeouts via the interaction mode from the DBus interface (Richard Hughes)
+
+* Bugfix:
+ - Add quit and contents accelerators in gpk-application (Matthias Clasen)
+ - Define a macro directory so we work with newer versions of libtool (Richard Hughes)
+ - Don't use gtk_dialog_get_action_area on gtk < 2.14 (Richard Hughes)
+ - Fix compile on F9 as gio is linked in explicitly (Richard Hughes)
+ - Make the confirm interaction more granular (Richard Hughes)
+ - When the restart mode is session then offer logout, rather than restart. Fixes RH#475781 (Richard Hughes)
+ - Truncate description fields greater than 1024 bytes in size to fix rh#475947 (Richard Hughes)
+ - We should do idle network actions on ONLINE (wireless or unknown) and FAST (ethernet) (Richard Hughes)
+ - Make sure the update description headers are top aligned, not centered (Richard Hughes)
+ - Use the markdown parser in gpk-application and gpk-update-viewer (Richard Hughes)
+ - Don't keep spinning the animation if the backend fails to send an update detail signal (Richard Hughes)
+ - Fix a small icon leak when showing the generic window with a custom icon (Richard Hughes)
+ - Fix two small memory leaks when installing fonts (Richard Hughes)
+ - Put the security updates in an array before we show the notification else
+   the number on the session critical notification is wrong (Richard Hughes)
+ - Output update descriptions with valid escaping to fix some descriptions (Richard Hughes)
+ - Fix a crash in gpk-application when doing run multiple times (Richard Hughes)
+ - Make error dialog resizable when error details are being shown. Fixes RH#478378 (Richard Hughes)
+ - Allow copy pasting of the update text in the update viewer (Richard Hughes)
+
 Version 0.4.0
 ~~~~~~~~~~~~~
 Released: 2008-12-09

Modified: trunk/configure.ac
==============================================================================
--- trunk/configure.ac	(original)
+++ trunk/configure.ac	Thu Jan  8 16:54:48 2009
@@ -1,6 +1,6 @@
 AC_PREREQ(2.52)
 
-AC_INIT(gnome-packagekit, 0.4.0)
+AC_INIT(gnome-packagekit, 0.4.2)
 AC_CONFIG_SRCDIR(src)
 AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
 AM_CONFIG_HEADER(config.h)

Modified: trunk/data/gpk-error.glade
==============================================================================
--- trunk/data/gpk-error.glade	(original)
+++ trunk/data/gpk-error.glade	Thu Jan  8 16:54:48 2009
@@ -4,7 +4,6 @@
 <glade-interface>
   <widget class="GtkDialog" id="dialog_error">
     <property name="border_width">6</property>
-    <property name="resizable">False</property>
     <property name="modal">True</property>
     <property name="window_position">GTK_WIN_POS_CENTER_ON_PARENT</property>
     <property name="destroy_with_parent">True</property>
@@ -124,7 +123,6 @@
             </child>
           </widget>
           <packing>
-            <property name="expand">False</property>
             <property name="position">1</property>
           </packing>
         </child>

Modified: trunk/src/gpk-cell-renderer-uri.c
==============================================================================
--- trunk/src/gpk-cell-renderer-uri.c	(original)
+++ trunk/src/gpk-cell-renderer-uri.c	Thu Jan  8 16:54:48 2009
@@ -49,9 +49,8 @@
 {
 	gpointer value;
 	g_return_val_if_fail (cru != NULL, FALSE);
-	if (cru->uri == NULL) {
+	if (cru->uri == NULL)
 		return FALSE;
-	}
 	value = g_hash_table_lookup (cru->clicked, cru->uri);
 	return (value != NULL);
 }
@@ -60,11 +59,10 @@
 gpk_cell_renderer_uri_set_clicked (GpkCellRendererUri *cru, gboolean clicked)
 {
 	g_return_if_fail (cru != NULL);
-	if (clicked) {
+	if (clicked)
 		g_hash_table_insert (cru->clicked, g_strdup (cru->uri), GINT_TO_POINTER (1));
-	} else {
+	else
 		g_hash_table_remove (cru->clicked, cru->uri);
-	}
 }
 
 static gboolean
@@ -76,9 +74,8 @@
 	GpkCellRendererUri *cru = GPK_CELL_RENDERER_URI (cell);
 
 	/* nothing to do */
-	if (cru->uri == NULL) {
+	if (cru->uri == NULL)
 		return TRUE;
-	}
 
 	gpk_cell_renderer_uri_set_clicked (cru, TRUE);
 
@@ -198,7 +195,7 @@
 	if (cru->uri == NULL) {
 		color = gdk_color_copy (&style->text[GTK_STATE_NORMAL]);
 		color_string = gdk_color_to_string (color);
-		g_object_set (G_OBJECT (cell), "foreground", color_string, NULL);
+		g_object_set (G_OBJECT (cru), "foreground", color_string, NULL);
 		g_object_set (G_OBJECT (cru), "underline", PANGO_UNDERLINE_NONE, NULL);
 	} else if (ret) {
 		/* if we defined this in our theme, else find a compromise */
@@ -208,7 +205,7 @@
 			gpk_cell_renderer_uri_set_link_color (color, TRUE);
 		}
 		color_string = gdk_color_to_string (color);
-		g_object_set (G_OBJECT (cell), "foreground", color_string, NULL);
+		g_object_set (G_OBJECT (cru), "foreground", color_string, NULL);
 		g_object_set (G_OBJECT (cru), "underline", PANGO_UNDERLINE_SINGLE, NULL);
 	} else {
 		/* if we defined this in our theme, else find a compromise */
@@ -218,15 +215,20 @@
 			gpk_cell_renderer_uri_set_link_color (color, FALSE);
 		}
 		color_string = gdk_color_to_string (color);
-		g_object_set (G_OBJECT (cell), "foreground", color_string, NULL);
+		g_object_set (G_OBJECT (cru), "foreground", color_string, NULL);
 		g_object_set (G_OBJECT (cru), "underline", PANGO_UNDERLINE_SINGLE, NULL);
 	}
 
 	gdk_color_free (color);
 	g_free (color_string);
 
-	/* we can click */
-	g_object_set (G_OBJECT (cru), "mode", GTK_CELL_RENDERER_MODE_ACTIVATABLE, NULL);
+	/* can we select the text or click it? */
+	if (cru->uri == NULL) {
+		g_object_set (G_OBJECT(cru), "editable", TRUE, NULL);
+		g_object_set (G_OBJECT(cru), "mode", GTK_CELL_RENDERER_MODE_EDITABLE, NULL);
+	} else  {
+		g_object_set (G_OBJECT(cru), "mode", GTK_CELL_RENDERER_MODE_ACTIVATABLE, NULL);
+	}
 
 	GTK_CELL_RENDERER_CLASS (parent_class)->render (cell, window, widget, background_area, cell_area, expose_area, flags);
 }

Modified: trunk/src/gpk-enum.c
==============================================================================
--- trunk/src/gpk-enum.c	(original)
+++ trunk/src/gpk-enum.c	Thu Jan  8 16:54:48 2009
@@ -440,6 +440,9 @@
 	case PK_ERROR_ENUM_INCOMPATIBLE_ARCHITECTURE:
 		text = _("Package is incompatible with this system");
 		break;
+	case PK_ERROR_ENUM_NO_SPACE_ON_DEVICE:
+		text = _("No space is left on the disk");
+		break;
 	default:
 		egg_warning ("Unknown error");
 	}
@@ -619,6 +622,10 @@
 	case PK_ERROR_ENUM_INCOMPATIBLE_ARCHITECTURE:
 		text = _("The package that is trying to be installed is incompatible with this system.");
 		break;
+	case PK_ERROR_ENUM_NO_SPACE_ON_DEVICE:
+		text = _("There is insufficient space on the device.\n"
+			 "Free some space on the system disk to perform this operation.");
+		break;
 	default:
 		egg_warning ("Unknown error, please report a bug at " GPK_BUGZILLA_URL ".\n"
 			    "More information is available in the detailed report.");

Modified: trunk/src/gpk-error.c
==============================================================================
--- trunk/src/gpk-error.c	(original)
+++ trunk/src/gpk-error.c	Thu Jan  8 16:54:48 2009
@@ -36,6 +36,24 @@
 #include "gpk-error.h"
 
 /**
+ * gpk_error_dialog_expanded_cb:
+ **/
+static void
+gpk_error_dialog_expanded_cb (GObject *object, GParamSpec *param_spec, GladeXML *glade_xml)
+{
+	GtkWidget *widget;
+	GtkExpander *expander;
+	expander = GTK_EXPANDER (object);
+
+	/* only resizable when expanded */
+	widget = glade_xml_get_widget (glade_xml, "dialog_error");
+	if (gtk_expander_get_expanded (expander))
+		gtk_window_set_resizable (GTK_WINDOW (widget), TRUE);
+	else
+		gtk_window_set_resizable (GTK_WINDOW (widget), FALSE);
+}
+
+/**
  * gpk_error_dialog_modal_with_time:
  * @window: the parent dialog
  * @title: the localised text to put in bold as a title
@@ -59,11 +77,17 @@
 
 	/* connect up actions */
 	widget = glade_xml_get_widget (glade_xml, "dialog_error");
+	gtk_window_set_resizable (GTK_WINDOW (widget), FALSE);
 	g_signal_connect_swapped (widget, "delete_event", G_CALLBACK (gtk_main_quit), NULL);
 
 	/* make modal if window set */
-	if (window != NULL)
+	if (window != NULL) {
 		gtk_window_set_transient_for (GTK_WINDOW (widget), window);
+		gtk_window_set_title (GTK_WINDOW (widget), "");
+	} else {
+		gtk_window_set_modal (GTK_WINDOW (widget), TRUE);
+		gtk_window_set_title (GTK_WINDOW (widget), title);
+	}
 
 	/* set icon name */
 	gtk_window_set_icon_name (GTK_WINDOW (widget), GPK_ICON_SOFTWARE_INSTALLER);
@@ -72,6 +96,10 @@
 	widget = glade_xml_get_widget (glade_xml, "button_close");
 	g_signal_connect_swapped (widget, "clicked", G_CALLBACK (gtk_main_quit), NULL);
 
+	/* we become resizable when the expander is expanded */
+	widget = glade_xml_get_widget (glade_xml, "expander_details");
+	g_signal_connect (widget, "notify::expanded", G_CALLBACK (gpk_error_dialog_expanded_cb), glade_xml);
+
 	/* title */
 	widget = glade_xml_get_widget (glade_xml, "label_title");
 	text = g_strdup_printf ("<b><big>%s</big></b>", title);
@@ -97,7 +125,6 @@
 	/* show window */
 	widget = glade_xml_get_widget (glade_xml, "dialog_error");
 	gtk_window_present_with_time (GTK_WINDOW (widget), timestamp);
-	gtk_window_set_title (GTK_WINDOW (widget), "");
 	gtk_window_set_icon_name (GTK_WINDOW (widget), GPK_ICON_SOFTWARE_INSTALLER);
 
 	/* wait for button press */
@@ -141,3 +168,29 @@
 	return gpk_error_dialog_modal (NULL, title, message, details);
 }
 
+/***************************************************************************
+ ***                          MAKE CHECK TESTS                           ***
+ ***************************************************************************/
+#ifdef EGG_TEST
+#include "egg-test.h"
+
+void
+gpk_error_test (EggTest *test)
+{
+	gboolean ret;
+
+	if (!egg_test_start (test, "GpkError"))
+		return;
+
+	/************************************************************/
+	egg_test_title (test, "do dialog");
+	ret = gpk_error_dialog ("No space is left on the disk",
+				"There is insufficient space on the device.\n"
+				"Free some space on the system disk to perform this operation.",
+				"[Errno 28] No space left on device");
+	egg_test_assert (test, ret);
+
+	egg_test_end (test);
+}
+#endif
+

Modified: trunk/src/gpk-self-test.c
==============================================================================
--- trunk/src/gpk-self-test.c	(original)
+++ trunk/src/gpk-self-test.c	Thu Jan  8 16:54:48 2009
@@ -33,6 +33,7 @@
 void gpk_language_test (EggTest *test);
 void gpk_client_dialog_test (EggTest *test);
 void gpk_client_test (EggTest *test);
+void gpk_error_test (EggTest *test);
 
 int
 main (int argc, char **argv)
@@ -54,6 +55,7 @@
 	gpk_common_test (test);
 //	gpk_dbus_test (test);
 	gpk_language_test (test);
+	gpk_error_test (test);
 	gpk_client_test (test);
 	gpk_client_dialog_test (test);
 

Modified: trunk/src/gpk-update-viewer.c
==============================================================================
--- trunk/src/gpk-update-viewer.c	(original)
+++ trunk/src/gpk-update-viewer.c	Thu Jan  8 16:54:48 2009
@@ -743,7 +743,7 @@
 
 	tree_view = glade_xml_get_widget (glade_xml, "treeview_description");
 	selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (tree_view));
-	gtk_tree_selection_set_mode (selection, GTK_SELECTION_NONE);
+	gtk_tree_selection_set_mode (selection, GTK_SELECTION_SINGLE);
 	gtk_tree_view_columns_autosize (GTK_TREE_VIEW (tree_view));
 }
 
@@ -890,7 +890,7 @@
 
 	/* split and add */
 	package_pretty = gpk_update_viewer_get_pretty_from_composite (obj->updates);
-	if (package_pretty != NULL) {
+	if (!egg_strzero (package_pretty)) {
 		/* TRANSLATORS: this is a list of packages that are updated */
 		gpk_update_viewer_add_description_item (_("Updates"), package_pretty, NULL);
 	}
@@ -898,7 +898,7 @@
 
 	/* split and add */
 	package_pretty = gpk_update_viewer_get_pretty_from_composite (obj->obsoletes);
-	if (package_pretty != NULL) {
+	if (!egg_strzero (package_pretty)) {
 		/* TRANSLATORS: this is a list of packages that are obsoleted */
 		gpk_update_viewer_add_description_item (_("Obsoletes"), package_pretty, NULL);
 	}
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]