gnome-terminal r3329 - trunk/src



Author: chpe
Date: Tue Feb 24 15:56:11 2009
New Revision: 3329
URL: http://svn.gnome.org/viewvc/gnome-terminal?rev=3329&view=rev

Log:
Bug 572549 â Memory corruption in gnome-terminal
Make sure to return a string dup.

Modified:
   trunk/src/terminal-screen.c

Modified: trunk/src/terminal-screen.c
==============================================================================
--- trunk/src/terminal-screen.c	(original)
+++ trunk/src/terminal-screen.c	Tue Feb 24 15:56:11 2009
@@ -1743,12 +1743,12 @@
   g_return_val_if_fail (TERMINAL_IS_SCREEN (screen), NULL);
 
   if (priv->pty_fd == -1)
-    return priv->initial_working_directory;
+    return g_strdup (priv->initial_working_directory);
 
   /* Get the foreground process ID */
   fgpid = tcgetpgrp (priv->pty_fd);
   if (fgpid == -1)
-    return priv->initial_working_directory;
+    return g_strdup (priv->initial_working_directory);
 
   /* Try to get the working directory using various OS-specific mechanisms */
   for (i = 0; i < G_N_ELEMENTS (patterns); ++i)
@@ -1788,7 +1788,7 @@
         }
     }
 
-  return priv->initial_working_directory;
+  return g_strdup (priv->initial_working_directory);
 }
 
 void



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]