evolution r37295 - in branches/kill-bonobo: addressbook/gui/component calendar/modules smime/gui

[mbarnes svn gnome org]

Author: mbarnes
Date: Thu Feb 19 12:31:06 2009
New Revision: 37295
URL: http://svn.gnome.org/viewvc/evolution?rev=37295&view=rev

Log:
Fix crash on startup.


Modified:
   branches/kill-bonobo/addressbook/gui/component/autocompletion-config.c
   branches/kill-bonobo/addressbook/gui/component/autocompletion-config.h
   branches/kill-bonobo/addressbook/gui/component/e-book-shell-module.c
   branches/kill-bonobo/calendar/modules/e-cal-shell-module.c
   branches/kill-bonobo/smime/gui/certificate-manager.c
   branches/kill-bonobo/smime/gui/certificate-manager.h

Modified: branches/kill-bonobo/addressbook/gui/component/autocompletion-config.c
==============================================================================
--- branches/kill-bonobo/addressbook/gui/component/autocompletion-config.c	(original)
+++ branches/kill-bonobo/addressbook/gui/component/autocompletion-config.c	Thu Feb 19 12:31:06 2009
@@ -24,12 +24,11 @@
 
 #include "autocompletion-config.h"
 
-#include <e-shell.h>
-#include <libedataserverui/e-name-selector-entry.h>
 #include <gtk/gtk.h>
 #include <glib/gi18n.h>
 #include <libedataserver/e-source-list.h>
 #include <libedataserverui/e-source-selector.h>
+#include <libedataserverui/e-name-selector-entry.h>
 
 #include "widgets/misc/e-preferences-window.h"
 
@@ -93,13 +92,14 @@
 }
 
 void
-autocompletion_config_init (void)
+autocompletion_config_init (EShell *shell)
 {
 	ESourceList *source_list;
 	GtkWidget *scrolled_window;
 	GtkWidget *source_selector;
 	GtkWidget *preferences_window;
-	EShell *shell;
+
+	g_return_if_fail (E_IS_SHELL (shell));
 
 	source_list = e_source_list_new_for_gconf_default (
 		"/apps/evolution/addressbook/sources");
@@ -125,7 +125,6 @@
 
 	initialize_selection (E_SOURCE_SELECTOR (source_selector));
 
-	shell = e_shell_get_default ();
 	preferences_window = e_shell_get_preferences_window (shell);
 
 	e_preferences_window_add_page (

Modified: branches/kill-bonobo/addressbook/gui/component/autocompletion-config.h
==============================================================================
--- branches/kill-bonobo/addressbook/gui/component/autocompletion-config.h	(original)
+++ branches/kill-bonobo/addressbook/gui/component/autocompletion-config.h	Thu Feb 19 12:31:06 2009
@@ -26,10 +26,11 @@
 #define _AUTOCOMPLETION_CONFIG_H
 
 #include <glib.h>
+#include <shell/e-shell.h>
 
 G_BEGIN_DECLS
 
-void		autocompletion_config_init	(void);
+void		autocompletion_config_init	(EShell *shell);
 
 G_END_DECLS
 

Modified: branches/kill-bonobo/addressbook/gui/component/e-book-shell-module.c
==============================================================================
--- branches/kill-bonobo/addressbook/gui/component/e-book-shell-module.c	(original)
+++ branches/kill-bonobo/addressbook/gui/component/e-book-shell-module.c	Thu Feb 19 12:31:06 2009
@@ -458,7 +458,7 @@
 	 *     things that use S/MIME.  Maybe put it in EShell? */
 #ifdef ENABLE_SMIME
 	smime_component_init ();
-	certificate_manager_config_init ();
+	certificate_manager_config_init (shell);
 #endif
 
 	book_module_init_importers ();
@@ -474,5 +474,5 @@
 		shell, "window-created",
 		G_CALLBACK (book_module_window_created_cb), shell_module);
 
-	autocompletion_config_init ();
+	autocompletion_config_init (shell);
 }

Modified: branches/kill-bonobo/calendar/modules/e-cal-shell-module.c
==============================================================================
--- branches/kill-bonobo/calendar/modules/e-cal-shell-module.c	(original)
+++ branches/kill-bonobo/calendar/modules/e-cal-shell-module.c	Thu Feb 19 12:31:06 2009
@@ -428,12 +428,10 @@
 };
 
 static void
-cal_module_init_preferences (void)
+cal_module_init_preferences (EShell *shell)
 {
 	GtkWidget *preferences_window;
-	EShell *shell;
 
-	shell = e_shell_get_default ();
 	preferences_window = e_shell_get_preferences_window (shell);
 
 	e_preferences_window_add_page (
@@ -508,5 +506,5 @@
 		shell, "window-created",
 		G_CALLBACK (cal_module_window_created_cb), shell_module);
 
-	cal_module_init_preferences ();
+	cal_module_init_preferences (shell);
 }

Modified: branches/kill-bonobo/smime/gui/certificate-manager.c
==============================================================================
--- branches/kill-bonobo/smime/gui/certificate-manager.c	(original)
+++ branches/kill-bonobo/smime/gui/certificate-manager.c	Thu Feb 19 12:31:06 2009
@@ -977,14 +977,15 @@
 }
 
 void
-certificate_manager_config_init (void)
+certificate_manager_config_init (EShell *shell)
 {
 	CertificateManagerData *cfm_data;
 	GtkWidget *preferences_window;
 	GtkWidget *widget;
-	EShell *shell;
 	char *gladefile;
 
+	g_return_if_fail (E_IS_SHELL (shell));
+
 	/* We need to peek the db here to make sure it (and NSS) are fully initialized. */
 	e_cert_db_peek ();
 
@@ -1031,7 +1032,6 @@
 	gtk_widget_set_sensitive(cfm_data->backup_your_button, FALSE);
 	gtk_widget_set_sensitive(cfm_data->backup_all_your_button, FALSE);
 
-	shell = e_shell_get_default ();
 	preferences_window = e_shell_get_preferences_window (shell);
 	e_preferences_window_add_page (
 		E_PREFERENCES_WINDOW (preferences_window),

Modified: branches/kill-bonobo/smime/gui/certificate-manager.h
==============================================================================
--- branches/kill-bonobo/smime/gui/certificate-manager.h	(original)
+++ branches/kill-bonobo/smime/gui/certificate-manager.h	Thu Feb 19 12:31:06 2009
@@ -24,10 +24,11 @@
 #define _CERTIFICATE_MANAGER_H
 
 #include <glib.h>
+#include <shell/e-shell.h>
 
 G_BEGIN_DECLS
 
-void		certificate_manager_config_init	(void);
+void		certificate_manager_config_init	(EShell *shell);
 
 G_END_DECLS