seed r852 - trunk/libseed

[hortont svn gnome org]

Author: hortont
Date: Sat Feb  7 09:39:53 2009
New Revision: 852
URL: http://svn.gnome.org/viewvc/seed?rev=852&view=rev

Log:
A note about a potential leak for Robb.


Modified:
   trunk/libseed/seed-types.c

Modified: trunk/libseed/seed-types.c
==============================================================================
--- trunk/libseed/seed-types.c	(original)
+++ trunk/libseed/seed-types.c	Sat Feb  7 09:39:53 2009
@@ -373,6 +373,8 @@
 					GValue *result;
 					guint i;
 
+					// TODO:FIXME: Robb. Valgrind thinks there's a leak here,
+					//             at least while running Same Seed.
 					result = g_new0(GValue, length + 1);
 
 					for (i = 0; i < length; i++)
@@ -1493,6 +1495,7 @@
 	gchar *utf8;
 
 	utf8 = g_filename_to_utf8(filename, -1, NULL, NULL, &e);
+	
 	if (e)
 	{
 		seed_make_exception_from_gerror(ctx, exception, e);
@@ -1501,7 +1504,11 @@
 		return NULL;
 	}
 
-	return seed_value_from_string(ctx, utf8, exception);
+	JSValueRef valstr = seed_value_from_string(ctx, utf8, exception);
+
+	g_free(utf8);
+
+	return valstr;
 }
 
 gchar *seed_value_to_filename(JSContextRef ctx,