[empathy] event-manager: remove the auto-remove timer when the event is destroyed
- From: Guillaume Desmottes <gdesmott src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [empathy] event-manager: remove the auto-remove timer when the event is destroyed
- Date: Mon, 21 Dec 2009 11:39:15 +0000 (UTC)
commit c80fb17f32ce997a631e228a7b6fd89d2120a09d
Author: Guillaume Desmottes <guillaume desmottes collabora co uk>
Date: Tue Dec 1 15:53:58 2009 +0000
event-manager: remove the auto-remove timer when the event is destroyed
This avoid to crash when trying to re-remove an old event (#603485).
src/empathy-event-manager.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
---
diff --git a/src/empathy-event-manager.c b/src/empathy-event-manager.c
index 72708b6..c9e925d 100644
--- a/src/empathy-event-manager.c
+++ b/src/empathy-event-manager.c
@@ -96,6 +96,7 @@ struct _EventPriv {
EventFunc func;
gboolean inhibit;
gpointer user_data;
+ guint autoremove_timeout_id;
};
enum {
@@ -160,6 +161,9 @@ event_free (EventPriv *event)
g_free (event->public.header);
g_free (event->public.message);
+ if (event->autoremove_timeout_id != 0)
+ g_source_remove (event->autoremove_timeout_id);
+
if (event->public.contact)
{
g_object_unref (event->public.contact);
@@ -174,6 +178,7 @@ event_remove (EventPriv *event)
EmpathyEventManagerPriv *priv = GET_PRIV (event->manager);
DEBUG ("Removing event %p", event);
+
priv->events = g_slist_remove (priv->events, event);
g_signal_emit (event->manager, signals[EVENT_REMOVED], 0, event);
event_free (event);
@@ -182,6 +187,7 @@ event_remove (EventPriv *event)
static gboolean
autoremove_event_timeout_cb (EventPriv *event)
{
+ event->autoremove_timeout_id = 0;
event_remove (event);
return FALSE;
}
@@ -219,8 +225,9 @@ event_manager_add (EmpathyEventManager *manager,
if (!event->public.must_ack)
{
- g_timeout_add_seconds (NOTIFICATION_TIMEOUT,
- (GSourceFunc) autoremove_event_timeout_cb, event);
+ event->autoremove_timeout_id = g_timeout_add_seconds (
+ NOTIFICATION_TIMEOUT, (GSourceFunc) autoremove_event_timeout_cb,
+ event);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]