[epiphany] Remove the 'favicon' signal from EphyWebView
- From: Xan Lopez <xan src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [epiphany] Remove the 'favicon' signal from EphyWebView
- Date: Fri, 11 Dec 2009 12:22:27 +0000 (UTC)
commit 012be8884f3fb3a618af3d7dfac29ad40de99f1a
Author: Xan Lopez <xan gnome org>
Date: Fri Dec 11 14:01:34 2009 +0200
Remove the 'favicon' signal from EphyWebView
We already have WebKitWebView::icon-loaded, so it's redundant now.
embed/ephy-embed.c | 9 ---------
embed/ephy-web-view.c | 19 +------------------
embed/ephy-web-view.h | 2 --
3 files changed, 1 insertions(+), 29 deletions(-)
---
diff --git a/embed/ephy-embed.c b/embed/ephy-embed.c
index fd981ce..b839c6b 100644
--- a/embed/ephy-embed.c
+++ b/embed/ephy-embed.c
@@ -772,14 +772,6 @@ load_error_cb (WebKitWebView *web_view,
}
static void
-icon_loaded_cb (WebKitWebView *web_view, const char* icon_uri, gpointer *data)
-{
- g_signal_emit_by_name (EPHY_WEB_VIEW (web_view),
- "favicon",
- icon_uri);
-}
-
-static void
ephy_embed_constructed (GObject *object)
{
EphyEmbed *embed = (EphyEmbed*)object;
@@ -802,7 +794,6 @@ ephy_embed_constructed (GObject *object)
"signal::notify::title", G_CALLBACK (title_changed_cb), embed,
"signal::notify::uri", G_CALLBACK (uri_changed_cb), embed,
"signal::load-error", G_CALLBACK (load_error_cb), embed,
- "signal::icon-loaded", G_CALLBACK (icon_loaded_cb), embed,
NULL);
embed->priv->inspector_window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c
index 04d3172..0d35810 100644
--- a/embed/ephy-web-view.c
+++ b/embed/ephy-web-view.c
@@ -694,23 +694,6 @@ ephy_web_view_class_init (EphyWebViewClass *klass)
G_TYPE_STRING | G_SIGNAL_TYPE_STATIC_SCOPE);
/**
- * EphyWebView::favicon:
- * @view: the #EphyWebView that received the signal
- * @address: the URL to @embed's web site's favicon
- *
- * The ::ge_favicon signal is emitted when @embed discovers that a favourite
- * icon (favicon) is available for the site it is visiting.
- **/
- g_signal_new ("favicon",
- EPHY_TYPE_WEB_VIEW,
- G_SIGNAL_RUN_FIRST,
- G_STRUCT_OFFSET (EphyWebViewClass, favicon),
- NULL, NULL,
- g_cclosure_marshal_VOID__STRING,
- G_TYPE_NONE,
- 1,
- G_TYPE_STRING | G_SIGNAL_TYPE_STATIC_SCOPE);
-/**
* EphyWebView::ge-search-link:
* @view: the #EphyWebView that received the signal
* @type: the mime-type of the search description
@@ -1077,7 +1060,7 @@ ephy_web_view_init (EphyWebView *web_view)
G_CALLBACK (mime_type_policy_decision_requested_cb),
NULL);
- g_signal_connect_object (web_view, "favicon",
+ g_signal_connect_object (web_view, "icon-loaded",
G_CALLBACK (favicon_cb),
web_view, (GConnectFlags)0);
diff --git a/embed/ephy-web-view.h b/embed/ephy-web-view.h
index 8a81853..0612f48 100644
--- a/embed/ephy-web-view.h
+++ b/embed/ephy-web-view.h
@@ -121,8 +121,6 @@ struct _EphyWebViewClass
WebKitWebViewClass parent_class;
/* Signals */
- void (* favicon) (EphyWebView *view,
- const char *location);
void (* feed_link) (EphyWebView *view,
const char *type,
const char *title,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]