[evolution-data-server/treitter-client-gdbus] Cut out some FIXMEs and make some of the debug output warnings

[Travis Reitter <treitter src gnome org>]

commit c7a338c0dc4ae5727fe709978b752f826df0dcad
Author: Travis Reitter <treitter gmail com>
Date:   Wed Dec 2 08:32:20 2009 -0800

    Cut out some FIXMEs and make some of the debug output warnings

 addressbook/libebook/e-book.c |   27 +++++++--------------------
 1 files changed, 7 insertions(+), 20 deletions(-)
---
diff --git a/addressbook/libebook/e-book.c b/addressbook/libebook/e-book.c
index daacbbc..0ad3c4b 100644
--- a/addressbook/libebook/e-book.c
+++ b/addressbook/libebook/e-book.c
@@ -246,8 +246,7 @@ e_book_activate(GError **error)
 		dbus_error_free (&derror);
 		UNLOCK_CONN ();
 
-		/* FIXME: cut this */
-		g_debug (G_STRLOC ": FAILED to start " E_DATA_BOOK_FACTORY_SERVICE_NAME);
+		g_warning (G_STRLOC ": FAILED to start " E_DATA_BOOK_FACTORY_SERVICE_NAME);
 
 		return FALSE;
 	}
@@ -272,24 +271,16 @@ e_book_activate(GError **error)
 		if (!connection_gdbus) {
 			UNLOCK_CONN ();
 
-			/* FIXME: cut this */
-			g_debug (G_STRLOC ": *** FAILED to create the factory connection gdbus");
+			g_warning (G_STRLOC ": failed to create the factory gdbus connection");
 
 			return FALSE;
 		}
-	} else {
-		/* FIXME: cut this */
-		g_debug (G_STRLOC ": *** already have a factory connection gdbus");
 	}
 
-	/* FIXME: it may be insufficient to create this; we probably have to
-	 * watch it to see if it dies. There's gdbusproxywatch for that */
-
-	/* FIXME: we don't need properties from this object, but what if we do
-	 * from others? -- maybe it's handled automatically if any properties
-	 * actually are defined? */
-	/* FIXME: same for signals - this doesn't have any, but what about the
-	 * other objects (which do have signals)? */
+	/* XXX: it's a bug in gdbus that we need to specify not to track
+	 * properties and signals (otherwise we can't create the proxy -- we'll
+	 * see if it works properly for D-Bus objects that do have properties or
+	 * signals) */
 	if (!factory_proxy_gdbus) {
 		factory_proxy_gdbus = g_dbus_proxy_new_sync (connection_gdbus,
 								G_TYPE_DBUS_PROXY,
@@ -302,16 +293,12 @@ e_book_activate(GError **error)
 		if (!factory_proxy_gdbus) {
 			UNLOCK_CONN ();
 
-			/* FIXME: cut this */
-			g_debug (G_STRLOC ": *** FAILED TO create the factory proxy gdbus, %s", (*error)->message);
+			g_warning (G_STRLOC ": failed to create the factory gdbus proxy, %s", (*error)->message);
 
 			return FALSE;
 		}
 
 		g_object_add_weak_pointer (G_OBJECT (factory_proxy_gdbus), (gpointer)&factory_proxy_gdbus);
-	} else {
-		/* FIXME: cut this */
-		g_debug (G_STRLOC ": *** already have a factory proxy gdbus");
 	}
 
 	UNLOCK_CONN ();