[glom/layout_name_enums] Removed some virtuals and made more API private.



commit ac509a17c2b0c97bf791816c2fadc75ffb679b8f
Author: Murray Cumming <murrayc murrayc com>
Date:   Fri Nov 20 17:21:45 2009 +0100

    Removed some virtuals and made more API private.

 glom/mode_design/layout/dialog_layout.h         |    9 ++++++++-
 glom/mode_design/layout/dialog_layout_details.h |   13 ++++++++-----
 glom/mode_design/layout/dialog_layout_export.h  |    2 +-
 3 files changed, 17 insertions(+), 7 deletions(-)
---
diff --git a/glom/mode_design/layout/dialog_layout.h b/glom/mode_design/layout/dialog_layout.h
index 215dbaf..25e1840 100644
--- a/glom/mode_design/layout/dialog_layout.h
+++ b/glom/mode_design/layout/dialog_layout.h
@@ -46,7 +46,7 @@ public:
    * @param table_name The table name.
    * @param table_fields: The actual fields in the table, in case the document does not yet know about them all.
    */
-  virtual void set_document(Document::LayoutName layout_name, const Glib::ustring& layout_platform, Document* document, const Glib::ustring& table_name, const type_vecLayoutFields& table_fields);
+  void set_document(Document::LayoutName layout_name, const Glib::ustring& layout_platform, Document* document, const Glib::ustring& table_name, const type_vecLayoutFields& table_fields);
 
   virtual bool get_modified() const;
 
@@ -60,14 +60,21 @@ protected:
   void move_treeview_selection_down(Gtk::TreeView* treeview, const Gtk::TreeModelColumn<guint>& sequence_column);
   void move_treeview_selection_up(Gtk::TreeView* treeview, const Gtk::TreeModelColumn<guint>& sequence_column);
 
+
   //signal handlers:
   virtual void on_treemodel_row_changed(const Gtk::TreeModel::Path& path, const Gtk::TreeModel::iterator& iter);
+
+private:
   virtual void on_entry_table_title_changed();
   virtual void on_button_close();
 
+protected:
   void make_sensitivity_depend_on_toggle_button(Gtk::ToggleButton& toggle_button, Gtk::Widget& widget);
+
+private:
   void on_sensitivity_toggle_button(Gtk::ToggleButton* toggle_button, Gtk::Widget* widget);
 
+protected:
   Gtk::Entry* m_entry_table_title;
   Gtk::Label* m_label_table_title;
 
diff --git a/glom/mode_design/layout/dialog_layout_details.h b/glom/mode_design/layout/dialog_layout_details.h
index f875399..a0c6bd0 100644
--- a/glom/mode_design/layout/dialog_layout_details.h
+++ b/glom/mode_design/layout/dialog_layout_details.h
@@ -40,17 +40,19 @@ public:
    * @param table_name The table name.
    * @param table_fields: The actual fields in the table, in case the document does not yet know about them all.
    */
-  virtual void set_document(Document::LayoutName layout_name, const Glib::ustring& layout_platform, Document* document, const Glib::ustring& table_name, const type_vecLayoutFields& table_fields);
+  void set_document(Document::LayoutName layout_name, const Glib::ustring& layout_platform, Document* document, const Glib::ustring& table_name, const type_vecLayoutFields& table_fields);
 
 protected:
 
-  virtual void add_group(const Gtk::TreeModel::iterator& parent, const sharedptr<const LayoutGroup>& group);
-  virtual void fill_group(const Gtk::TreeModel::iterator& iter, sharedptr<LayoutGroup>& group);
+  void add_group(const Gtk::TreeModel::iterator& parent, const sharedptr<const LayoutGroup>& group);
+
+private:
+  void fill_group(const Gtk::TreeModel::iterator& iter, sharedptr<LayoutGroup>& group);
 
   //Enable/disable buttons, depending on treeview selection:
-  virtual void enable_buttons();
+  virtual void enable_buttons(); //overridden.
 
-  virtual void save_to_document();
+  virtual void save_to_document(); //overridden.
 
   sharedptr<Relationship> offer_relationship_list();
   sharedptr<Relationship> offer_relationship_list(const sharedptr<const Relationship>& relationship);
@@ -86,6 +88,7 @@ protected:
 
   Gtk::TreeModel::iterator append_appropriate_row();
 
+protected:
   Gtk::TreeView* m_treeview_fields;
   Gtk::TreeView::Column* m_treeview_column_title;
   Gtk::TreeView::Column* m_treeview_column_group_columns;
diff --git a/glom/mode_design/layout/dialog_layout_export.h b/glom/mode_design/layout/dialog_layout_export.h
index e7fd7ea..1196677 100644
--- a/glom/mode_design/layout/dialog_layout_export.h
+++ b/glom/mode_design/layout/dialog_layout_export.h
@@ -38,7 +38,7 @@ public:
    * @param table_name The table name.
    * @param table_fields: The actual fields in the table, in case the document does not yet know about them all.
    */
-  virtual void set_layout_groups(Document::type_list_layout_groups& mapGroups, Document* document, const Glib::ustring& table_name);
+  void set_layout_groups(Document::type_list_layout_groups& mapGroups, Document* document, const Glib::ustring& table_name);
 
   void get_layout_groups(Document::type_list_layout_groups& layout_groups) const;
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]