[rhythmbox] player-gst: don't unref NULL if there's no volume handler element



commit 1bd7782a3d9c26a9c1bef844fab7145b81104f2b
Author: Jonathan Matthew <jonathan d14n org>
Date:   Sun Aug 30 21:40:27 2009 +1000

    player-gst: don't unref NULL if there's no volume handler element

 backends/gstreamer/rb-player-gst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/backends/gstreamer/rb-player-gst.c b/backends/gstreamer/rb-player-gst.c
index 2dbf024..55a517e 100644
--- a/backends/gstreamer/rb-player-gst.c
+++ b/backends/gstreamer/rb-player-gst.c
@@ -804,8 +804,8 @@ impl_play (RBPlayer *player, RBPlayerPlayType play_type, gint64 crossfade, GErro
 			e = rb_player_gst_find_element_with_property (mp->priv->audio_sink, "volume");
 			if (e != NULL) {
 				mp->priv->volume_applied = 1;
+				gst_object_unref (e);
 			}
-			gst_object_unref (e);
 
 			if (mp->priv->volume_applied < mp->priv->volume_changed) {
 				float volume = mp->priv->cur_volume * mp->priv->replaygain_scale;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]