[glom] Remove a nasty hack that would become a runtime bug.
- From: Murray Cumming <murrayc src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [glom] Remove a nasty hack that would become a runtime bug.
- Date: Thu, 27 Aug 2009 13:56:13 +0000 (UTC)
commit 5671b37b8ea0f7c90de1f90260780c042890e880
Author: Murray Cumming <murrayc murrayc com>
Date: Thu Aug 27 15:55:20 2009 +0200
Remove a nasty hack that would become a runtime bug.
* glom/libglom/connectionpool_backends/sqlite.cc: Revert the previous
hack by Johannes, which misused GLIBMM_EXCEPTIONS_ENABLE to
avoid use of CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE. We will
just update libgdamm on Maemo Fremantle instead.
ChangeLog | 9 +++++++++
glom/libglom/connectionpool_backends/sqlite.cc | 4 ++--
2 files changed, 11 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 8ccde92..677da9c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
2009-08-27 Murray Cumming <murrayc murrayc com>
+ Remove a nasty hack that would become a runtime bug.
+
+ * glom/libglom/connectionpool_backends/sqlite.cc: Revert the previous
+ hack by Johannes, which misused GLIBMM_EXCEPTIONS_ENABLE to
+ avoid use of CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE. We will
+ just update libgdamm on Maemo Fremantle instead.
+
+2009-08-27 Murray Cumming <murrayc murrayc com>
+
Really never use config.h in libglom.
* glom/libglom/*.cc: Remove some remaining includes of config.h
diff --git a/glom/libglom/connectionpool_backends/sqlite.cc b/glom/libglom/connectionpool_backends/sqlite.cc
index 73169f8..71f0e76 100644
--- a/glom/libglom/connectionpool_backends/sqlite.cc
+++ b/glom/libglom/connectionpool_backends/sqlite.cc
@@ -73,7 +73,7 @@ Glib::RefPtr<Gnome::Gda::Connection> Sqlite::connect(const Glib::ustring& databa
std::auto_ptr<Glib::Error> error;
connection = Gnome::Gda::Connection::open_from_string("SQLite",
cnc_string, auth_string,
- Gnome::Gda::CONNECTION_OPTIONS_NONE /* Gnome::Gda::CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE */, error);
+ Gnome::Gda::CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE, error);
if(error.get())
{
const Glib::Error& ex = *error.get();
@@ -117,7 +117,7 @@ bool Sqlite::create_database(const Glib::ustring& database_name, const Glib::ust
Glib::RefPtr<Gnome::Gda::Connection> cnc =
Gnome::Gda::Connection::open_from_string("SQLite",
cnc_string, "",
- Gnome::Gda::CONNECTION_OPTIONS_NONE /* Gnome::Gda::CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE */, error);
+ Gnome::Gda::CONNECTION_OPTIONS_SQL_IDENTIFIERS_CASE_SENSITIVE, error);
if(error.get() != 0)
return false;
#endif
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]