[empathy/mc5: 218/483] Ignore default value for required params



commit 6bd8c2d7d8589d3d0019599c75de05b20ae18f44
Author: Cosimo Cecchi <cosimoc gnome org>
Date:   Wed Jul 29 23:11:07 2009 +0200

    Ignore default value for required params
    
    Parameters should never have both the default and the required flags
    set, as required means the user has to fill in a value. When this
    happens anyway, the default dlag should be ignored, so we can avoid
    looking up the default value when checking for an account settings'
    validity.

 libempathy/empathy-account-settings.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
---
diff --git a/libempathy/empathy-account-settings.c b/libempathy/empathy-account-settings.c
index 21109d2..1c5bc71 100644
--- a/libempathy/empathy-account-settings.c
+++ b/libempathy/empathy-account-settings.c
@@ -1072,10 +1072,6 @@ empathy_account_settings_is_valid (EmpathyAccountSettings *settings)
             continue;
         }
 
-      /* see if there's a default value */
-      if (empathy_account_settings_get_default (settings, current))
-        continue;
-
       missed = TRUE;
       break;
     }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]