[libsoup/cache] Revert "soup-cache: keep the session alive until we are done flushing it to disk"



commit fbcbf0ab0b7e04b65b2a1ae8cfa3e577b1985d54
Author: Xan Lopez <xan gnome org>
Date:   Wed Aug 5 11:24:10 2009 +0300

    Revert "soup-cache: keep the session alive until we are done flushing it to disk"
    
    This reverts commit f87fab4bde7fce3eb964227a1c3a38de7634d09b.
    
    This seems to break things quite badly in some cases, revert it for now.

 libsoup/soup-cache.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)
---
diff --git a/libsoup/soup-cache.c b/libsoup/soup-cache.c
index 2ea2296..00ffde8 100644
--- a/libsoup/soup-cache.c
+++ b/libsoup/soup-cache.c
@@ -383,9 +383,6 @@ close_ready_cb (GObject *source, GAsyncResult *result, SoupCacheWritingFixture *
 	entry->pos = 0;
 
 	cache->priv->n_pending--;
-
-	/* Unref the session */
-	g_object_unref (cache->priv->session);
 }
 
 static void
@@ -536,10 +533,6 @@ append_to_ready_cb (GObject *source, GAsyncResult *result, SoupCacheWritingFixtu
 	if (error) {
 		entry->error = error;
 		fixture->cache->priv->n_pending--;
-
-		/* Unref the session here, since we weren't able to
-		   even open the stream for writing */
-		g_object_unref (fixture->cache->priv->session);
 		return;
 	}
 
@@ -593,9 +586,6 @@ msg_got_headers_cb (SoupMessage *msg, SoupCache *cache)
 		fixture->cache = cache;
 		fixture->entry = entry;
 
-		/* Ref the session to keep it alive until we are done writing */
-		g_object_ref (cache->priv->session);
-
 		/* We connect now to these signals and buffer the data
 		   if it comes before the file is ready for writing */
 		g_signal_connect (msg, "got-chunk", G_CALLBACK (msg_got_chunk_cb), fixture);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]